Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "[#6430] Adaptive ForEachElement does not exit when child acti… #6466

Merged
merged 1 commit into from
Sep 7, 2022
Merged

Revert "[#6430] Adaptive ForEachElement does not exit when child acti… #6466

merged 1 commit into from
Sep 7, 2022

Conversation

tracyboehrer
Copy link
Member

Fixes #6428

Revert "[#6430] Adaptive ForEachElement does not exit when child acti…
07c8e34 
…on CancelAllDialogs is called (#6452)"

This reverts commit c572be3.
@tracyboehrer tracyboehrer requested a review from a team as a code owner September 7, 2022 20:59
@tracyboehrer tracyboehrer added the Automation: No parity PR does not need to be applied to other languages. label Sep 7, 2022
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 320699

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.006%) to 79.079%
Files with Coverage Reduction New Missed Lines %
/libraries/Microsoft.Bot.Builder.Dialogs.Adaptive/Actions/ForEachElement.cs 2 89.31%
Totals Coverage Status
Change from base Build 320507: 0.006%
Covered Lines: 25582
Relevant Lines: 32350
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 9b2b6d6 into main Sep 7, 2022
@tracyboehrer tracyboehrer deleted the tracyboehrer/revertForEachElement branch September 7, 2022 21:16
tracyboehrer added a commit that referenced this pull request Sep 7, 2022
@tracyboehrer
Revert "[#6430] Adaptive ForEachElement does not exit when child acti…
0966055 
…on CancelAllDialogs is called (#6452)" (#6466)

This reverts commit c572be3.

Co-authored-by: Tracy Boehrer <[email protected]>
tracyboehrer added a commit that referenced this pull request Sep 7, 2022
@tracyboehrer @sw-joelmut
4.17.2 Patch Update - Reversion of breaking change (#6467)
8307e64 
* Revert "[#6430] Adaptive ForEachElement does not exit when child action CancelAllDialogs is called (#6452)" (#6466)

This reverts commit c572be3.

Co-authored-by: Tracy Boehrer <[email protected]>

* Add cancellation token to TeamsOperation class (#6458)

* Fix typing indicator shown after bot has replied (#6460)

Co-authored-by: Tracy Boehrer <[email protected]>
Co-authored-by: Joel Mut <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Automation: No parity PR does not need to be applied to other languages.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adaptive ForEachElement loop's incorrectly when changes cause ContinueDialogAsync to be recalled
2 participants
@tracyboehrer @coveralls