Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: Add settings.selectedChannel to TeamsChannelData and Type to ChannelInfo and TeamDetails (#6360) #4274

Closed
github-actions bot opened this issue Jul 7, 2022 · 0 comments · Fixed by #4295
Closed

port: Add settings.selectedChannel to TeamsChannelData and Type to ChannelInfo and TeamDetails (#6360) #4274

github-actions bot opened this issue Jul 7, 2022 · 0 comments · Fixed by #4295
Assignees
@JuanAr
Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.

Comments

@github-actions
Copy link

github-actions bot commented Jul 7, 2022

The changes in Add settings.selectedChannel to TeamsChannelData and Type to ChannelInfo and TeamDetails (#6360) may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6349

Please review and, if necessary, port the changes.
@github-actions github-actions bot added ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms. labels Jul 7, 2022
@sw-joelmut sw-joelmut mentioned this issue Jul 26, 2022
Merged
tracyboehrer pushed a commit that referenced this issue Jul 26, 2022
@sw-joelmut
port: [#4274] Add settings.selectedChannel to TeamsChannelData and Ty…
38627fc 
…pe to ChannelInfo and TeamDetails (#6360) (#4295)

* Add teamsGetSelectedChannelId function

* Add unit tests for teamsGetSelectedChannelId function

* Update botframework-schema compat

* Update botbuilder compat

* Fix TeamsChannelData doc and reorder imports
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@JuanAr JuanAr

Labels
ExemptFromDailyDRIReport Use this label to exclude the issue from the DRI report. needs-triage The issue has just been created and it has not been reviewed by the team. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
1 participant
@JuanAr