Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

port: [#4274] Add settings.selectedChannel to TeamsChannelData and Type to ChannelInfo and TeamDetails (#6360) #4295

Merged
merged 5 commits into from
Jul 26, 2022

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #4274

Description

This PR adds the ability to gather the selected MS Team's channel id when available in the incoming Activity. (Available in Install and Uninstall the teams' bot events).

Specific Changes

  • Added the teamsGetSelectedChannelId helper function.
  • Added the TeamsChannelDataSettings interface and all its related properties to be accessible from the Activity.
  • Added unit tests around this implementation.
  • Updated mappers to include the new added properties.
  • Updated compatibility Markdown document.

Testing

The following images show the tests passing successfully and the selected channel id being gathered successfully from a teams' bot.
imagen
imagen

@sw-joelmut sw-joelmut requested a review from a team as a code owner July 26, 2022 12:54
@coveralls
Copy link

coveralls commented Jul 26, 2022

Pull Request Test Coverage Report for Build 2739621062

  • 4 of 4 (100.0%) changed or added relevant lines in 2 files are covered.
  • 1 unchanged line in 1 file lost coverage.
  • Overall coverage increased (+0.003%) to 84.515%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
Totals Coverage Status
Change from base Build 2732579521: 0.003%
Covered Lines: 19942
Relevant Lines: 22350

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 38627fc into main Jul 26, 2022
@tracyboehrer tracyboehrer deleted the southworks/add/teams-selected-channel branch July 26, 2022 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

port: Add settings.selectedChannel to TeamsChannelData and Type to ChannelInfo and TeamDetails (#6360)
3 participants