Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Replace Node.js packages in botframework-streaming #2617

Closed
wants to merge 6 commits into from

Conversation

stevengum
Copy link
Member

Fixes #

Description

Specific Changes

Testing

@stevengum stevengum self-assigned this Jul 30, 2020
@coveralls
Copy link

coveralls commented Jul 30, 2020

Pull Request Test Coverage Report for Build 151908

  • 48 of 55 (87.27%) changed or added relevant lines in 7 files are covered.
  • 16 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.09%) to 82.606%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botframework-streaming/src/webSocket/node/nodeWebSocketClient.ts 22 29 75.86%
Files with Coverage Reduction New Missed Lines %
libraries/botframework-streaming/src/protocolAdapter.ts 1 78.38%
libraries/botframework-streaming/src/webSocket/webSocketTransport.ts 1 81.55%
libraries/botframework-streaming/src/webSocket/webSocketClient.ts 14 29.73%
Totals Coverage Status
Change from base Build 151887: -0.09%
Covered Lines: 14840
Relevant Lines: 17055

💛 - Coveralls

@joshgummersall joshgummersall changed the base branch from master to main September 29, 2020 16:30
@joshgummersall joshgummersall linked an issue Oct 13, 2020 that may be closed by this pull request
@joshgummersall
Copy link
Contributor

Replaced by #2942.

@stevengum stevengum deleted the stgum/webpack branch June 7, 2021 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Node.js packages in botframework-streaming
3 participants