Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

browserify botframework-streaming #2942

Merged
merged 8 commits into from
Oct 23, 2020
Merged

Conversation

joshgummersall
Copy link
Contributor

Fixes #2311

Browserify produces a browser-friendly bundle without native Node.js packages.

@compulim is there an easy way for you to test this out? I've produced the bundle locally to ensure that it works:

jpg@za-coglyn0606 ~/s/g/m/b/l/botframework-streaming (jpg/bf-streaming-browserify +)> npm run build

> [email protected] build /Users/jpg/src/gh/microsoft/bb-js/libraries/botframework-streaming
> npm-run-all -p build:lib build:es5


> [email protected] build:es5 /Users/jpg/src/gh/microsoft/bb-js/libraries/botframework-streaming
> tsc -p tsconfig-es5.json


> [email protected] build:lib /Users/jpg/src/gh/microsoft/bb-js/libraries/botframework-streaming
> tsc -p tsconfig.json


> [email protected] postbuild /Users/jpg/src/gh/microsoft/bb-js/libraries/botframework-streaming
> browserify -s BFSE --debug es5/index-browser.js | exorcist lib/index-browser.js.map | sponge lib/index-browser.js

jpg@za-coglyn0606 ~/s/g/m/b/l/botframework-streaming (jpg/bf-streaming-browserify +)> open index.html
jpg@za-coglyn0606 ~/s/g/m/b/l/botframework-streaming (jpg/bf-streaming-browserify +)> node -e "console.log(require('./lib/index-browser.js'))"
{
  ContentStream: [Function: ContentStream],
  HttpContent: [Function: HttpContent],
  RequestHandler: [Function: RequestHandler],
  StreamingRequest: [Function: StreamingRequest] { create: [Function] },
  StreamingResponse: [Function: StreamingResponse] { create: [Function] },
  SubscribableStream: [Function: SubscribableStream],
  BrowserWebSocket: [Function: BrowserWebSocket],
  WebSocketClient: [Function: WebSocketClient]
}

Screen Shot 2020-10-22 at 1 40 58 PM

Copy link
Member

@stevengum stevengum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI is failing, but I've validated this branch with the latest in WebChat and a DL-ASE bot. Once we figure out is going on with the E2E test, let's merge the PR.

@Zerryth
Copy link
Contributor

Zerryth commented Oct 23, 2020

Also validated that it works in end-to-end streaming scenario. 🎇 🎃 🎉 🎊

@joshgummersall joshgummersall merged commit b6a74f5 into main Oct 23, 2020
@joshgummersall joshgummersall deleted the jpg/bf-streaming-browserify branch October 23, 2020 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Node.js packages in botframework-streaming
3 participants