Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed unused method in teamsActivityHandler #4260

Merged
merged 5 commits into from
Jun 15, 2022
Merged

fix: Removed unused method in teamsActivityHandler #4260

merged 5 commits into from
Jun 15, 2022

Conversation

ramfattah
Copy link
Contributor

Fixes #4259

Description

Invoke activity with the name adaptiveCard/action is supported in ActivityHandler class, the method handleAdaptiveCardAction is not needed in teamsActivityHandler class.

Specific Changes

@ramfattah ramfattah requested a review from a team as a code owner June 7, 2022 23:00
@ramfattah ramfattah changed the title removed unused method teamsActivityHandler fix: removed unused method teamsActivityHandler Jun 7, 2022
@coveralls
Copy link

coveralls commented Jun 7, 2022 •
edited
Loading

Pull Request Test Coverage Report for Build 2466178915

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage decreased (-0.001%) to 84.482%
Totals Coverage Status
Change from base Build 2436995787: -0.001%
Covered Lines: 19901
Relevant Lines: 22308
💛 - Coveralls

@ramfattah ramfattah changed the title fix: removed unused method teamsActivityHandler fix: removed unused method in teamsActivityHandler Jun 7, 2022
@ramfattah ramfattah marked this pull request as draft June 9, 2022 05:14
@ramfattah ramfattah marked this pull request as draft June 9, 2022 05:14
@ramfattah ramfattah marked this pull request as ready for review June 9, 2022 06:02
@ramfattah ramfattah changed the title fix: removed unused method in teamsActivityHandler fix: Removed unused method in teamsActivityHandler Jun 9, 2022
@tracyboehrer tracyboehrer merged commit 2ff22a7 into main Jun 15, 2022
@tracyboehrer tracyboehrer deleted the ramfattah/teamsActivityHandler branch June 15, 2022 20:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricDahlvang EricDahlvang EricDahlvang approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing support for adaptiveCard/action type invoke in TeamsActivityHandler
4 participants
@ramfattah @coveralls @EricDahlvang @tracyboehrer