Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Removed unused method in teamsActivityHandler #4260

Merged
merged 5 commits into from
Jun 15, 2022
Merged

fix: Removed unused method in teamsActivityHandler #4260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
074a669
removed handleAdaptiveCardAction method
ramfattah Jun 7, 2022
e011b48
update public API signature
ramfattah Jun 8, 2022
ec171da
Revert "update public API signature"
ramfattah Jun 9, 2022
c4723a1
Update teamsActivityHandler.ts
ramfattah Jun 9, 2022
7188ffa
update public API signature
ramfattah Jun 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions libraries/botbuilder/etc/botbuilder.api.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,6 @@
import { Activity } from 'botbuilder-core';
import { ActivityHandler } from 'botbuilder-core';
import { ActivityHandlerBase } from 'botbuilder-core';
import { AdaptiveCardInvokeResponse } from 'botbuilder-core';
import { AppBasedLinkQuery } from 'botbuilder-core';
import { AppCredentials } from 'botframework-connector';
import { AttachmentData } from 'botbuilder-core';
Expand Down Expand Up @@ -356,7 +355,6 @@ export class StreamingHttpClient implements HttpClient {
export class TeamsActivityHandler extends ActivityHandler {
protected dispatchConversationUpdateActivity(context: TurnContext): Promise<void>;
protected dispatchEventActivity(context: TurnContext): Promise<void>;
protected handleAdaptiveCardAction(_context: TurnContext): Promise<AdaptiveCardInvokeResponse>;
protected handleTeamsAppBasedLinkQuery(_context: TurnContext, _query: AppBasedLinkQuery): Promise<MessagingExtensionResponse>;
protected handleTeamsCardActionInvoke(_context: TurnContext): Promise<InvokeResponse>;
protected handleTeamsFileConsent(context: TurnContext, fileConsentCardResponse: FileConsentCardResponse): Promise<void>;
Expand Down
11 changes: 0 additions & 11 deletions libraries/botbuilder/src/teamsActivityHandler.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,6 @@

import {
ActivityHandler,
AdaptiveCardInvokeResponse,
AppBasedLinkQuery,
ChannelInfo,
Channels,
Expand Down Expand Up @@ -514,16 +513,6 @@ export class TeamsActivityHandler extends ActivityHandler {
throw new Error('NotImplemented');
}

/**
* Receives invoke activities with the name 'adaptiveCard/action'
*
* @param _context A context object for this turn.
* @returns The Messaging Extension Action Response for the query.
*/
protected async handleAdaptiveCardAction(_context: TurnContext): Promise<AdaptiveCardInvokeResponse> {
throw new Error('NotImplemented');
}

/**
* Receives invoke activities with the name 'composeExtension/setting'
*
Expand Down