Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#4463][#6596] TeamsChannelData need OnBehalfOf #4474

Merged
merged 3 commits into from
May 8, 2023
Merged

port: [#4463][#6596] TeamsChannelData need OnBehalfOf #4474

merged 3 commits into from
May 8, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #4463

Description

This PR ports the changes in .NET to add the OnBehalfOf property and send messages via bots on behalf of another user in Teams.

Specific Changes

  • Added the OnBehalfOf property in the TeamsChannelData interface.
  • Added the teamsGetTeamOnBehalfOf method in teamsActivityHelpers to return the current activity's OnBehalfOf list.
  • Added unit tests in teamsHelpers.test to cover the new code.

Testing

The following image shows the message of the bot on behalf of another user in the Teams channel.
image

@ceciliaavila ceciliaavila requested a review from a team as a code owner May 5, 2023 18:12
@coveralls
Copy link

coveralls commented May 5, 2023 •
edited
Loading

Pull Request Test Coverage Report for Build 4896313205

  • 5 of 5 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.4%) to 84.863%
Totals Coverage Status
Change from base Build 4894039401: 0.4%
Covered Lines: 20099
Relevant Lines: 22455
💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 04a6175 into main May 8, 2023
@tracyboehrer tracyboehrer deleted the southworks/add/onbehalfof-property branch May 8, 2023 14:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tracyboehrer tracyboehrer tracyboehrer approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

port: [#6596] TeamsChannelData need OnBehalfOf
4 participants
@ceciliaavila @coveralls @tracyboehrer @JhontSouth