Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

port: [#6596] TeamsChannelData need OnBehalfOf #4463

Closed
ceciliaavila opened this issue Apr 27, 2023 · 0 comments · Fixed by #4474
Closed

port: [#6596] TeamsChannelData need OnBehalfOf #4463

ceciliaavila opened this issue Apr 27, 2023 · 0 comments · Fixed by #4474
Assignees
@ceciliaavila
Labels
feature-request A request for new functionality or an enhancement to an existing one. parity The issue describes a gap in parity between two or more platforms.

Comments

@ceciliaavila
Copy link
Collaborator

ceciliaavila commented Apr 27, 2023 •
edited
Loading

The changes in microsoft/botbuilder-dotnet#6609 may need to be ported to maintain parity with microsoft/botbuilder-dotnet.

Fixes #6596

Description

This PR adds the OnBehalfOf property to send messages via bots on behalf of another user in Teams.
It also adds unit tests to cover the new code.

Specific Changes

  • Added the OnBehalfOf property in the TeamsChannelData class.
  • Added the TeamsGetTeamOnBehalfOf method to return the current activity's OnBehalfOf list.

Testing

The following image shows the message of the bot on behalf of another user in the Teams channel.
image

The following image shows the related unit test passing.
image
@ceciliaavila ceciliaavila added feature-request A request for new functionality or an enhancement to an existing one. parity The issue describes a gap in parity between two or more platforms. labels Apr 27, 2023
@ceciliaavila ceciliaavila self-assigned this Apr 27, 2023
@ceciliaavila ceciliaavila mentioned this issue May 5, 2023
Merged
tracyboehrer pushed a commit that referenced this issue May 8, 2023
@ceciliaavila @JhontSouth
port: [#4463][#6596] TeamsChannelData need OnBehalfOf (#4474)
04a6175 
* add onBehalfOf property to Teams channel

* fix code requirements

---------

Co-authored-by: JhontSouth <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@ceciliaavila ceciliaavila

Labels
feature-request A request for new functionality or an enhancement to an existing one. parity The issue describes a gap in parity between two or more platforms.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

port: [#4463][#6596] TeamsChannelData need OnBehalfOf microsoft/botbuilder-js
1 participant
@ceciliaavila