Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump: [#4550] Add Node 18 and 20 support #4726

Merged
merged 2 commits into from
Aug 26, 2024

Conversation

sw-joelmut
Copy link
Collaborator

Fixes #4550
Fixes #4709

Important

Node 14 and 16 versions have been removed from the testing pipeline execution due to packages that require newer versions of Node and don't support them.

Description

This PR updates @microsoft/orchestrator-core from 4.14.4 to 4.15.1 that was preventing Node 18+ installations due to non-existing binaries available for them.
Additionally, it adds support for Node 18 and 20 versions to allow installation of newer versions of packages like Azure Identity and MSAL that have Node 18+ limitation.
We updated all pipelines to target the latest LTS Node version, and for the testing one we also included Node 18 and above.

Specific Changes

  • Pipelines updated to run against Node 18 and 20.
  • Added bf-cli package installation as global dependency in the test:schemas pipeline due to having the Orchestrator-Core limitation yet.
  • Updated @microsoft/orchestrator-core from 4.14.4 to 4.15.1 that support newer versions of node.
  • Updated @azure/msal-node to latest 2.13.0 version.
  • Updated @azure/identity to latest 4.4.1 version. Fixing CVE-2024-35255.
  • Added validation checks for newer versions of TypeScript, 4.3 and 4.4 were removed from this validation since they aren't working in Node 18 and 20.
  • Replaced browserify with tsup in botframework-connector.
  • Fixed multiple tests due to Node version changes.

Testing

The following images show the new botframework-connector browser compilation, the MultiTenant, SingleTenant, Certificate, and MSI type of authentications working.
image
image
image

@sw-joelmut sw-joelmut requested a review from a team as a code owner August 23, 2024 20:16
@coveralls
Copy link

coveralls commented Aug 23, 2024

Pull Request Test Coverage Report for Build 10531815490

Details

  • 15 of 16 (93.75%) changed or added relevant lines in 9 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.3%) to 84.403%

Changes Missing Coverage Covered Lines Changed/Added Lines %
libraries/botbuilder-ai/src/globals.ts 2 3 66.67%
Totals Coverage Status
Change from base Build 10180631754: 0.3%
Covered Lines: 20433
Relevant Lines: 22912

💛 - Coveralls

@tracyboehrer tracyboehrer merged commit 604e190 into main Aug 26, 2024
13 checks passed
@tracyboehrer tracyboehrer deleted the southworks/add/node-18-20-support branch August 26, 2024 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Upgrade @azure/identity version in botframework-connector Need support for Node.js 20
4 participants