Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: CVE-2024-39338 vulnerability with axios #4728

Closed
wants to merge 2 commits into from

Conversation

JhontSouth
Copy link
Collaborator

#minor

Description

This PR updates the axios version to 1.7.4 to avoid the CVE-2024-39338 vulnerability.

Specific Changes

  • Updated axios from 1.7.2 to 1.7.4 in every library.

Testing

The following image shows the axios version installed.
image

@JhontSouth JhontSouth requested a review from a team as a code owner August 26, 2024 14:36
@coveralls
Copy link

coveralls commented Aug 26, 2024

Pull Request Test Coverage Report for Build 10562083732

Warning: This coverage report may be inaccurate.

This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 82 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.4%) to 84.048%

Files with Coverage Reduction New Missed Lines %
libraries/botbuilder-lg/src/templateExtensions.ts 1 84.48%
libraries/botframework-streaming/src/utilities/createNodeServer.ts 1 78.57%
libraries/botframework-streaming/src/namedPipe/namedPipeServer.ts 12 50.68%
libraries/botframework-streaming/src/namedPipe/namedPipeClient.ts 17 34.09%
libraries/botframework-streaming/src/namedPipe/namedPipeTransport.ts 51 3.92%
Totals Coverage Status
Change from base Build 10561941421: -0.4%
Covered Lines: 20351
Relevant Lines: 22912

💛 - Coveralls

@tracyboehrer
Copy link
Member

@JhontSouth Conflicts

@tracyboehrer
Copy link
Member

@JhontSouth Duplicate? of #4730

@JhontSouth
Copy link
Collaborator Author

@JhontSouth Duplicate? of #4730

Yes, Dependabot created it after the merge of PR#4726

@JhontSouth
Copy link
Collaborator Author

Fixed in #4730

@JhontSouth JhontSouth closed this Sep 10, 2024
@JhontSouth JhontSouth deleted the southworks/fix/axios-vulnerability branch September 10, 2024 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants