Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port: TeamsChannelData need OnBehalfOf [#6609] #2175

Merged
merged 3 commits into from
Oct 7, 2024

Conversation

gandiddi
Copy link
Collaborator

@gandiddi gandiddi commented Oct 3, 2024

Fixes #minor

Description

This PR ports the changes from microsoft/botbuilder-dotnet#6609

  • Adds the OnBehalfOf property to send messages via bots on behalf of another user in Teams.
  • It also adds unit tests to cover the new code.

Specific Changes

  • Added the OnBehalfOf property in the TeamsChannelData class.
  • Added the teams_get_team_on_behalf_of method to return the current activity's OnBehalfOf list.

Testing

The following image shows the related unit test passing.
image

@gandiddi gandiddi requested a review from a team as a code owner October 3, 2024 14:13
@gandiddi gandiddi changed the title Port: Add OnBehalfOf property to send messages via bots on behalf of another user in Teams. Port: TeamsChannelData need OnBehalfOf [#6609] Oct 3, 2024
@gandiddi gandiddi merged commit 1617885 into main Oct 7, 2024
7 checks passed
@gandiddi gandiddi deleted the v-gandiddi/add-onbehalfof-property branch October 7, 2024 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants