Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[#6596] TeamsChannelData need OnBehalfOf #6609

Merged
merged 5 commits into from
Apr 20, 2023

Conversation

ceciliaavila
Copy link
Collaborator

Fixes #6596

Description

This PR adds the OnBehalfOf property to send messages via bots on behalf of another user in Teams.
It also adds unit tests to cover the new code.

Specific Changes

  • Added the OnBehalfOf property in the TeamsChannelData class.
  • Added the TeamsGetTeamOnBehalfOf method to return the current activity's OnBehalfOf list.

Testing

The following image shows the message of the bot on behalf of another user in the Teams channel.
image

The following image shows the related unit test passing.
image

@ceciliaavila ceciliaavila added the Automation: Parity with js The PR needs to be ported to JS label Mar 28, 2023
@ceciliaavila ceciliaavila requested a review from a team as a code owner March 28, 2023 15:34
@coveralls
Copy link
Collaborator

Pull Request Test Coverage Report for Build 345844

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 8 unchanged lines in 5 files lost coverage.
  • Overall coverage decreased (-0.008%) to 79.096%

Files with Coverage Reduction New Missed Lines %
/libraries/AdaptiveExpressions/BuiltinFunctions/GetNextViableTime.cs 1 90.91%
/libraries/AdaptiveExpressions/BuiltinFunctions/GetPreviousViableTime.cs 1 90.91%
/libraries/Microsoft.Bot.Streaming/Payloads/StreamManager.cs 1 90.0%
/libraries/Microsoft.Bot.Streaming/Transport/NamedPipe/NamedPipeClient.cs 1 71.43%
/libraries/Microsoft.Bot.Builder/Teams/TeamsActivityExtensions.cs 4 78.26%
Totals Coverage Status
Change from base Build 344537: -0.008%
Covered Lines: 25817
Relevant Lines: 32640

💛 - Coveralls

@BruceHaley
Copy link
Contributor

✔️ No Binary Compatibility issues for Microsoft.Bot.Builder.dll
✔️ No Binary Compatibility issues for Microsoft.Bot.Schema.dll

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Automation: Parity with js The PR needs to be ported to JS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

TeamsChannelData need OnBehalfOf
6 participants