Allow building with HTTP compression support without WebSockets #875
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BillyONeal
requested changes
Oct 1, 2018
| @@ -75,6 +75,7 @@ if(CPPREST_EXCLUDE_COMPRESSION) | |||
| else() | |||
| cpprest_find_zlib() | |||
| target_link_libraries(cpprest PRIVATE cpprestsdk_zlib_internal) | |||
| target_compile_definitions(cpprest PRIVATE -DCPPREST_HTTP_COMPRESSION=1) | |||
There was a problem hiding this comment.
The macro CPPRESET_HTTP_COMPRESSION is an internal macro to http_helpers.cpp, and we shouldn't be messing with it from the build scripts like this.
The comment there indicates that the macro 'CPPREST_EXCLUDE_WEBSOCKETS is a flag that now essentially means "no external dependencies"', and zlib would be such an external dependency.
Perhaps the right thing is to change the bits in http_helpers.cpp to avoid checking CPPREST_EXCLUDE_WEBSOCKETS.
|
Obsoleted by PR #866. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, even if
CPPREST_EXCLUDE_COMPRESSIONis not set, HTTP compression support is disabled when WebSockets is disabled, even though it appears to only depend on zlib.This PR allows building the library with HTTP compression without a dependency on OpenSSL and Boost.