Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow building with HTTP compression support without WebSockets #875

Closed
wants to merge 1 commit into from
Closed

Allow building with HTTP compression support without WebSockets #875

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions Release/src/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,7 @@ if(CPPREST_EXCLUDE_COMPRESSION)
else()
cpprest_find_zlib()
target_link_libraries(cpprest PRIVATE cpprestsdk_zlib_internal)
target_compile_definitions(cpprest PRIVATE -DCPPREST_HTTP_COMPRESSION=1)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macro CPPRESET_HTTP_COMPRESSION is an internal macro to http_helpers.cpp, and we shouldn't be messing with it from the build scripts like this.

The comment there indicates that the macro 'CPPREST_EXCLUDE_WEBSOCKETS is a flag that now essentially means "no external dependencies"', and zlib would be such an external dependency.

Perhaps the right thing is to change the bits in http_helpers.cpp to avoid checking CPPREST_EXCLUDE_WEBSOCKETS.

endif()

# PPLX component
Expand Down