feat(tools): enable multiple package migration via --name option #20583
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
9 tasks
📊 Bundle size report🤖 This report was generated against c62593339a19c6abbabed742a0cc83fa9a85b97e |
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: c62593339a19c6abbabed742a0cc83fa9a85b97e (build) |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 566993c:
|
Perf Analysis (
|
| Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
|---|---|---|---|---|---|
| Avatar | mount | 1041 | 1063 | 5000 | |
| BaseButton | mount | 1071 | 1016 | 5000 | |
| Breadcrumb | mount | 2744 | 2732 | 1000 | |
| ButtonNext | mount | 584 | 581 | 5000 | |
| Checkbox | mount | 1709 | 1739 | 5000 | |
| CheckboxBase | mount | 1487 | 1532 | 5000 | |
| ChoiceGroup | mount | 5204 | 5219 | 5000 | |
| ComboBox | mount | 1067 | 1047 | 1000 | |
| CommandBar | mount | 10791 | 10778 | 1000 | |
| ContextualMenu | mount | 9047 | 8906 | 1000 | |
| DefaultButton | mount | 1276 | 1305 | 5000 | |
| DetailsRow | mount | 4178 | 4148 | 5000 | |
| DetailsRowFast | mount | 4196 | 4279 | 5000 | |
| DetailsRowNoStyles | mount | 3990 | 3982 | 5000 | |
| Dialog | mount | 2766 | 2729 | 1000 | |
| DocumentCardTitle | mount | 171 | 180 | 1000 | |
| Dropdown | mount | 3598 | 3604 | 5000 | |
| FluentProviderNext | mount | 4047 | 4098 | 5000 | |
| FluentProviderWithTheme | mount | 237 | 233 | 10 | |
| FluentProviderWithTheme | virtual-rerender | 104 | 105 | 10 | |
| FluentProviderWithTheme | virtual-rerender-with-unmount | 261 | 269 | 10 | |
| FocusTrapZone | mount | 1917 | 1998 | 5000 | |
| FocusZone | mount | 1941 | 1976 | 5000 | |
| IconButton | mount | 2008 | 1968 | 5000 | |
| Label | mount | 389 | 390 | 5000 | |
| Layer | mount | 3251 | 3321 | 5000 | |
| Link | mount | 552 | 536 | 5000 | |
| MakeStyles | mount | 1891 | 1920 | 50000 | |
| MenuButton | mount | 1633 | 1705 | 5000 | |
| MessageBar | mount | 2144 | 2111 | 5000 | |
| Nav | mount | 3691 | 3604 | 1000 | |
| OverflowSet | mount | 1241 | 1174 | 5000 | |
| Panel | mount | 2612 | 2697 | 1000 | |
| Persona | mount | 941 | 959 | 1000 | |
| Pivot | mount | 1535 | 1586 | 1000 | |
| PrimaryButton | mount | 1440 | 1412 | 5000 | |
| Rating | mount | 8710 | 8877 | 5000 | |
| SearchBox | mount | 1516 | 1458 | 5000 | |
| Shimmer | mount | 2912 | 2798 | 5000 | |
| Slider | mount | 2155 | 2110 | 5000 | |
| SpinButton | mount | 5607 | 5533 | 5000 | |
| Spinner | mount | 463 | 451 | 5000 | |
| SplitButton | mount | 3412 | 3520 | 5000 | |
| Stack | mount | 598 | 601 | 5000 | |
| StackWithIntrinsicChildren | mount | 1914 | 1964 | 5000 | |
| StackWithTextChildren | mount | 5276 | 5252 | 5000 | |
| SwatchColorPicker | mount | 11309 | 11569 | 5000 | |
| TagPicker | mount | 2870 | 2955 | 5000 | |
| TeachingBubble | mount | 13736 | 13839 | 5000 | |
| Text | mount | 469 | 483 | 5000 | |
| TextField | mount | 1573 | 1523 | 5000 | |
| ThemeProvider | mount | 1325 | 1286 | 5000 | |
| ThemeProvider | virtual-rerender | 658 | 690 | 5000 | |
| ThemeProvider | virtual-rerender-with-unmount | 2037 | 2080 | 5000 | |
| Toggle | mount | 968 | 887 | 5000 | |
| buttonNative | mount | 153 | 150 | 5000 |
Perf Analysis (@fluentui/react-northstar)
Perf tests with no regressions
| Scenario | Current PR Ticks | Baseline Ticks | Ratio |
|---|---|---|---|
| ButtonMinimalPerf.default | 216 | 192 | 1.13:1 |
| AccordionMinimalPerf.default | 186 | 171 | 1.09:1 |
| AnimationMinimalPerf.default | 480 | 442 | 1.09:1 |
| ImageMinimalPerf.default | 443 | 411 | 1.08:1 |
| TreeWith60ListItems.default | 202 | 189 | 1.07:1 |
| HeaderMinimalPerf.default | 424 | 401 | 1.06:1 |
| MenuMinimalPerf.default | 978 | 924 | 1.06:1 |
| ReactionMinimalPerf.default | 440 | 417 | 1.06:1 |
| BoxMinimalPerf.default | 394 | 374 | 1.05:1 |
| ListNestedPerf.default | 660 | 626 | 1.05:1 |
| TableManyItemsPerf.default | 2227 | 2119 | 1.05:1 |
| TableMinimalPerf.default | 447 | 425 | 1.05:1 |
| TextAreaMinimalPerf.default | 585 | 555 | 1.05:1 |
| AttachmentSlotsPerf.default | 1213 | 1171 | 1.04:1 |
| CheckboxMinimalPerf.default | 2999 | 2870 | 1.04:1 |
| MenuButtonMinimalPerf.default | 1897 | 1826 | 1.04:1 |
| ChatWithPopoverPerf.default | 444 | 433 | 1.03:1 |
| DialogMinimalPerf.default | 859 | 831 | 1.03:1 |
| DividerMinimalPerf.default | 396 | 384 | 1.03:1 |
| GridMinimalPerf.default | 375 | 365 | 1.03:1 |
| LayoutMinimalPerf.default | 398 | 388 | 1.03:1 |
| ListCommonPerf.default | 754 | 734 | 1.03:1 |
| SliderMinimalPerf.default | 1882 | 1819 | 1.03:1 |
| TreeMinimalPerf.default | 915 | 892 | 1.03:1 |
| ChatDuplicateMessagesPerf.default | 338 | 332 | 1.02:1 |
| ListMinimalPerf.default | 579 | 570 | 1.02:1 |
| LoaderMinimalPerf.default | 754 | 741 | 1.02:1 |
| RadioGroupMinimalPerf.default | 531 | 520 | 1.02:1 |
| SkeletonMinimalPerf.default | 405 | 399 | 1.02:1 |
| CustomToolbarPrototype.default | 4424 | 4317 | 1.02:1 |
| TooltipMinimalPerf.default | 1159 | 1140 | 1.02:1 |
| VideoMinimalPerf.default | 700 | 688 | 1.02:1 |
| CarouselMinimalPerf.default | 513 | 506 | 1.01:1 |
| DatepickerMinimalPerf.default | 5958 | 5871 | 1.01:1 |
| EmbedMinimalPerf.default | 4656 | 4620 | 1.01:1 |
| InputMinimalPerf.default | 1439 | 1423 | 1.01:1 |
| LabelMinimalPerf.default | 433 | 428 | 1.01:1 |
| SegmentMinimalPerf.default | 431 | 426 | 1.01:1 |
| AttachmentMinimalPerf.default | 185 | 185 | 1:1 |
| ButtonSlotsPerf.default | 626 | 627 | 1:1 |
| FormMinimalPerf.default | 472 | 472 | 1:1 |
| ProviderMinimalPerf.default | 1299 | 1293 | 1:1 |
| ItemLayoutMinimalPerf.default | 1331 | 1340 | 0.99:1 |
| ListWith60ListItems.default | 726 | 732 | 0.99:1 |
| SplitButtonMinimalPerf.default | 4621 | 4669 | 0.99:1 |
| StatusMinimalPerf.default | 740 | 745 | 0.99:1 |
| IconMinimalPerf.default | 687 | 691 | 0.99:1 |
| TextMinimalPerf.default | 386 | 391 | 0.99:1 |
| AlertMinimalPerf.default | 300 | 305 | 0.98:1 |
| CardMinimalPerf.default | 599 | 610 | 0.98:1 |
| DropdownManyItemsPerf.default | 756 | 772 | 0.98:1 |
| RosterPerf.default | 1351 | 1381 | 0.98:1 |
| AvatarMinimalPerf.default | 220 | 226 | 0.97:1 |
| ChatMinimalPerf.default | 729 | 755 | 0.97:1 |
| DropdownMinimalPerf.default | 3367 | 3480 | 0.97:1 |
| PopupMinimalPerf.default | 616 | 632 | 0.97:1 |
| ProviderMergeThemesPerf.default | 1817 | 1867 | 0.97:1 |
| RefMinimalPerf.default | 248 | 255 | 0.97:1 |
| HeaderSlotsPerf.default | 815 | 847 | 0.96:1 |
| ButtonOverridesMissPerf.default | 1895 | 1985 | 0.95:1 |
| ToolbarMinimalPerf.default | 1013 | 1074 | 0.94:1 |
| FlexMinimalPerf.default | 325 | 349 | 0.93:1 |
| PortalMinimalPerf.default | 190 | 204 | 0.93:1 |
Hotell
force-pushed
the
hotell/build-tools/tools-allow-multi-package-migration
branch
from
2c76f56
to
24f287a
Compare
ling1726
approved these changes
Nov 11, 2021
ecraig12345
approved these changes
Nov 11, 2021
Co-authored-by: Elizabeth Craig <[email protected]>
Co-authored-by: Peter Varholak <[email protected]>
Co-authored-by: Peter Varholak <[email protected]>
mlp73
pushed a commit
to mlp73/fluentui
that referenced
this pull request
Jan 17, 2022
…rosoft#20583) * feat(tools): enable multiple package migration via --name option * Update tools/generators/migrate-converged-pkg/index.ts Co-authored-by: Elizabeth Craig <[email protected]> * Update tools/generators/migrate-converged-pkg/schema.ts Co-authored-by: Peter Varholak <[email protected]> * feat(tools): create overriden getProjects function that enables filtering Co-authored-by: Elizabeth Craig <[email protected]> Co-authored-by: Peter Varholak <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull request checklist
[ ] Include a change request file using$ yarn changeDescription of changes
Adds support to run migration on multiple packages
Before:
After:
# run migration on react-text and react-image in one run yarn nx workspace-generator migrate-converged-pkg --name=@fluentui/react-text,@fluentui/react-imageFocus areas to test
(optional)