-
Notifications
You must be signed in to change notification settings - Fork 2.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(tools): update --stats to get proper data for ts solution config… #20584
feat(tools): update --stats to get proper data for ts solution config… #20584
Conversation
📊 Bundle size report🤖 This report was generated against fe9829e4818f9bb7206df37747d5da332706ae4b |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🇱🇰
Asset size changesSize Auditor did not detect a change in bundle size for any component! Baseline commit: fe9829e4818f9bb7206df37747d5da332706ae4b (build) |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 1a65758:
|
Perf Analysis (
|
Scenario | Render type | Master Ticks | PR Ticks | Iterations | Status |
---|---|---|---|---|---|
Avatar | mount | 1027 | 1030 | 5000 | |
BaseButton | mount | 1059 | 1029 | 5000 | |
Breadcrumb | mount | 2775 | 2766 | 1000 | |
ButtonNext | mount | 580 | 580 | 5000 | |
Checkbox | mount | 1755 | 1706 | 5000 | |
CheckboxBase | mount | 1465 | 1456 | 5000 | |
ChoiceGroup | mount | 5243 | 5216 | 5000 | |
ComboBox | mount | 1031 | 1079 | 1000 | |
CommandBar | mount | 11080 | 10879 | 1000 | |
ContextualMenu | mount | 8903 | 9000 | 1000 | |
DefaultButton | mount | 1229 | 1275 | 5000 | |
DetailsRow | mount | 4099 | 4095 | 5000 | |
DetailsRowFast | mount | 4095 | 4102 | 5000 | |
DetailsRowNoStyles | mount | 3912 | 3944 | 5000 | |
Dialog | mount | 2849 | 2827 | 1000 | |
DocumentCardTitle | mount | 186 | 171 | 1000 | |
Dropdown | mount | 3528 | 3532 | 5000 | |
FluentProviderNext | mount | 3978 | 4114 | 5000 | |
FluentProviderWithTheme | mount | 241 | 241 | 10 | |
FluentProviderWithTheme | virtual-rerender | 103 | 112 | 10 | |
FluentProviderWithTheme | virtual-rerender-with-unmount | 267 | 291 | 10 | |
FocusTrapZone | mount | 1996 | 1976 | 5000 | |
FocusZone | mount | 1892 | 1903 | 5000 | |
IconButton | mount | 2052 | 1987 | 5000 | |
Label | mount | 371 | 399 | 5000 | |
Layer | mount | 3185 | 3263 | 5000 | |
Link | mount | 541 | 531 | 5000 | |
MakeStyles | mount | 1895 | 1895 | 50000 | |
MenuButton | mount | 1764 | 1670 | 5000 | |
MessageBar | mount | 2169 | 2167 | 5000 | |
Nav | mount | 4031 | 3715 | 1000 | |
OverflowSet | mount | 1216 | 1218 | 5000 | |
Panel | mount | 2633 | 2696 | 1000 | |
Persona | mount | 934 | 933 | 1000 | |
Pivot | mount | 1552 | 1540 | 1000 | |
PrimaryButton | mount | 1456 | 1490 | 5000 | |
Rating | mount | 8935 | 8764 | 5000 | |
SearchBox | mount | 1494 | 1511 | 5000 | |
Shimmer | mount | 2812 | 2905 | 5000 | |
Slider | mount | 2149 | 2174 | 5000 | |
SpinButton | mount | 5574 | 5489 | 5000 | |
Spinner | mount | 458 | 469 | 5000 | |
SplitButton | mount | 3525 | 3552 | 5000 | |
Stack | mount | 581 | 582 | 5000 | |
StackWithIntrinsicChildren | mount | 1979 | 2040 | 5000 | |
StackWithTextChildren | mount | 5383 | 5503 | 5000 | |
SwatchColorPicker | mount | 11418 | 12194 | 5000 | |
TagPicker | mount | 2949 | 2869 | 5000 | |
TeachingBubble | mount | 13704 | 13972 | 5000 | |
Text | mount | 486 | 474 | 5000 | |
TextField | mount | 1517 | 1541 | 5000 | |
ThemeProvider | mount | 1270 | 1270 | 5000 | |
ThemeProvider | virtual-rerender | 635 | 657 | 5000 | |
ThemeProvider | virtual-rerender-with-unmount | 2131 | 2100 | 5000 | |
Toggle | mount | 921 | 874 | 5000 | |
buttonNative | mount | 135 | 135 | 5000 |
Perf Analysis (@fluentui/react-northstar
)
Perf tests with no regressions
Scenario | Current PR Ticks | Baseline Ticks | Ratio |
---|---|---|---|
ChatDuplicateMessagesPerf.default | 352 | 315 | 1.12:1 |
TreeWith60ListItems.default | 220 | 199 | 1.11:1 |
AttachmentMinimalPerf.default | 197 | 182 | 1.08:1 |
CardMinimalPerf.default | 676 | 626 | 1.08:1 |
LabelMinimalPerf.default | 468 | 432 | 1.08:1 |
AvatarMinimalPerf.default | 244 | 227 | 1.07:1 |
FormMinimalPerf.default | 505 | 472 | 1.07:1 |
SegmentMinimalPerf.default | 431 | 401 | 1.07:1 |
SkeletonMinimalPerf.default | 433 | 409 | 1.06:1 |
TableMinimalPerf.default | 478 | 453 | 1.06:1 |
BoxMinimalPerf.default | 409 | 391 | 1.05:1 |
MenuButtonMinimalPerf.default | 1944 | 1856 | 1.05:1 |
FlexMinimalPerf.default | 324 | 313 | 1.04:1 |
LayoutMinimalPerf.default | 436 | 421 | 1.04:1 |
ListMinimalPerf.default | 607 | 583 | 1.04:1 |
ListNestedPerf.default | 670 | 645 | 1.04:1 |
ListWith60ListItems.default | 776 | 745 | 1.04:1 |
LoaderMinimalPerf.default | 824 | 791 | 1.04:1 |
RefMinimalPerf.default | 261 | 250 | 1.04:1 |
TooltipMinimalPerf.default | 1191 | 1146 | 1.04:1 |
AttachmentSlotsPerf.default | 1236 | 1205 | 1.03:1 |
HeaderMinimalPerf.default | 435 | 422 | 1.03:1 |
InputMinimalPerf.default | 1485 | 1442 | 1.03:1 |
ItemLayoutMinimalPerf.default | 1421 | 1374 | 1.03:1 |
ReactionMinimalPerf.default | 458 | 444 | 1.03:1 |
IconMinimalPerf.default | 709 | 689 | 1.03:1 |
ToolbarMinimalPerf.default | 1068 | 1040 | 1.03:1 |
TreeMinimalPerf.default | 902 | 872 | 1.03:1 |
ChatMinimalPerf.default | 777 | 764 | 1.02:1 |
DatepickerMinimalPerf.default | 6079 | 5962 | 1.02:1 |
DialogMinimalPerf.default | 846 | 829 | 1.02:1 |
DropdownMinimalPerf.default | 3465 | 3387 | 1.02:1 |
GridMinimalPerf.default | 389 | 382 | 1.02:1 |
PopupMinimalPerf.default | 668 | 655 | 1.02:1 |
ProviderMergeThemesPerf.default | 1899 | 1870 | 1.02:1 |
TableManyItemsPerf.default | 2220 | 2177 | 1.02:1 |
TextMinimalPerf.default | 385 | 377 | 1.02:1 |
CarouselMinimalPerf.default | 533 | 527 | 1.01:1 |
CheckboxMinimalPerf.default | 3032 | 2989 | 1.01:1 |
DropdownManyItemsPerf.default | 811 | 804 | 1.01:1 |
ProviderMinimalPerf.default | 1312 | 1293 | 1.01:1 |
SliderMinimalPerf.default | 1907 | 1888 | 1.01:1 |
CustomToolbarPrototype.default | 4556 | 4509 | 1.01:1 |
ButtonMinimalPerf.default | 204 | 205 | 1:1 |
ButtonOverridesMissPerf.default | 1993 | 2003 | 1:1 |
EmbedMinimalPerf.default | 4732 | 4709 | 1:1 |
HeaderSlotsPerf.default | 869 | 873 | 1:1 |
RosterPerf.default | 1420 | 1424 | 1:1 |
TextAreaMinimalPerf.default | 585 | 584 | 1:1 |
AccordionMinimalPerf.default | 174 | 176 | 0.99:1 |
AnimationMinimalPerf.default | 453 | 456 | 0.99:1 |
DividerMinimalPerf.default | 405 | 408 | 0.99:1 |
ImageMinimalPerf.default | 448 | 451 | 0.99:1 |
MenuMinimalPerf.default | 973 | 982 | 0.99:1 |
PortalMinimalPerf.default | 192 | 194 | 0.99:1 |
RadioGroupMinimalPerf.default | 537 | 541 | 0.99:1 |
SplitButtonMinimalPerf.default | 4869 | 4941 | 0.99:1 |
AlertMinimalPerf.default | 325 | 333 | 0.98:1 |
ListCommonPerf.default | 735 | 756 | 0.97:1 |
StatusMinimalPerf.default | 798 | 826 | 0.97:1 |
ButtonSlotsPerf.default | 619 | 646 | 0.96:1 |
ChatWithPopoverPerf.default | 439 | 456 | 0.96:1 |
VideoMinimalPerf.default | 683 | 717 | 0.95:1 |
… migration
Pull request checklist
[ ] Include a change request file using$ yarn change
Description of changes
--stats
flag to provide data for migration status to TS Solution config files for vNextFocus areas to test
(optional)