test: simplify test cases to reduce calls to gpt #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reduce test cases without reducing coverage
## Description <!-- Prefix the PR title with 'feat:' to increment the minor version, or 'fix:' to increment the patch version --> <!-- Describe what changes this PR introduces and their effects --> <!-- Update documentation if there are any changes to existing features or APIs --> ## Testing <!-- Describe how you tested your changes and how reviewers can test them --> <!-- Ensure all code can be tested offline (unmarked tests) and online (marked as 'integration') --> ## Additional context <!-- Add any other context about your changes here --> <!-- ## Breaking Changes --> <!-- List any breaking changes introduced by this PR and their implications and include '!' in the prefix. -->
## Description <!-- Prefix the PR title with 'feat:' to increment the minor version, or 'fix:' to increment the patch version --> <!-- Describe what changes this PR introduces and their effects --> <!-- Update documentation if there are any changes to existing features or APIs --> ## Testing <!-- Describe how you tested your changes and how reviewers can test them --> <!-- Ensure all code can be tested offline (unmarked tests) and online (marked as 'integration') --> ## Additional context <!-- Add any other context about your changes here --> <!-- ## Breaking Changes --> <!-- List any breaking changes introduced by this PR and their implications and include '!' in the prefix. -->
dciborow
changed the title
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary by GPT-4
This commit makes several changes to the test suite for the GPT CLI:
- It refactors the test cases into data classes, making it easier to manage and understand the different test cases.
- It adds new test cases for different CLI options and error scenarios.
- It updates some of the existing test cases to use more descriptive variable names and improve readability.
- It adds new tests for running the CLI as a module, ensuring that it works correctly when invoked in this way.
Overall, these changes should make the test suite more robust and easier to maintain in the future.
Suggestions
Here are some suggestions for improving the changes in this PR:
- In
.github/workflows/python.yml, update theactions/setup-pythonversion to the latest one (currently v3) instead of v4, which does not exist yet.
- - uses: actions/setup-python@v4
+ - uses: actions/setup-python@v3- In
tests/conftest.py, add a docstring to themock_queryfunction for better readability.
def mock_query(self, question) -> MockQueryResponse:
"""
Mock query function for testing purposes.
"""
return MockQueryResponse()- In
tests/test_gpt_cli.py, consider adding comments to each group of test cases (e.g., ROOT_COMMANDS, ASK_COMMANDS, etc.) to provide a brief explanation of what they are testing.
Other than these minor suggestions, the changes in this PR look good and well-organized.
dciborow
commented
May 9, 2023
Codecov Report
@@ Coverage Diff @@
## main #69 +/- ##
==========================================
+ Coverage 89.14% 89.17% +0.02%
==========================================
Files 14 14
Lines 433 434 +1
Branches 65 65
==========================================
+ Hits 386 387 +1
Misses 34 34
Partials 13 13
Flags with carried forward coverage won't be shown. Click here to find out more.
|
danay1999
approved these changes
May 9, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Testing
Additional context