-
Notifications
You must be signed in to change notification settings - Fork 34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Parses navvis origin file and converts into Capture::Lamar csv file #65
Conversation
vjlux
commented
Apr 5, 2024
- More tests missing
Do new NavVis devices have GPS? I've never seen this CRS field. |
Navvis not. But u can align navvis data to georefeenced coordinate systems
in ivion and u get this fiels
…On Sat, Apr 6, 2024, 9:38 AM Paul-Edouard Sarlin ***@***.***> wrote:
Do new NavVis devices have GPS? I've never seen this CRS field.
—
Reply to this email directly, view it on GitHub
<#65 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/ACMZ6NAEPIJQN6A7AH5YFQDY36RABAVCNFSM6AAAAABFY5OWS2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDANBRGAYDIOBUGI>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Nit: remove the whit spaces.
Please also update the |
scantools/capture/namedposes.py
Outdated
from ..utils.io import read_csv, write_csv | ||
|
||
|
||
class NamedPoses(dict): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't this redundant with capture.proc.GlobalAlignment
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok.. I can write here now. was looking at it with the wrong account. I changed it using GlobalAlignment.
I wonder if I should just go with proc/global_alignment but this would be more involved. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm