Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parses navvis origin file and converts into Capture::Lamar csv file #65

Merged
merged 25 commits into from
Jun 11, 2024

Conversation

vjlux
Copy link
Collaborator

@vjlux vjlux commented Apr 5, 2024

  • More tests missing

@sarlinpe
Copy link
Collaborator

sarlinpe commented Apr 6, 2024

Do new NavVis devices have GPS? I've never seen this CRS field.

@vjlux
Copy link
Collaborator Author

vjlux commented Apr 6, 2024 via email

Copy link
Contributor

@pablospe pablospe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Nit: remove the whit spaces.

scantools/capture/records.py Outdated Show resolved Hide resolved
scantools/capture/records.py Show resolved Hide resolved
scantools/run_navvis_to_capture.py Outdated Show resolved Hide resolved
scantools/scanners/navvis/navvis.py Show resolved Hide resolved
scantools/scanners/navvis/origin_parser.py Outdated Show resolved Hide resolved
scantools/scanners/navvis/origin_parser.py Show resolved Hide resolved
@pablospe
Copy link
Contributor

Please also update the CAPTURE.md to include the origin output:
https://github.com/microsoft/lamar-benchmark/blob/main/CAPTURE.md

from ..utils.io import read_csv, write_csv


class NamedPoses(dict):
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't this redundant with capture.proc.GlobalAlignment?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok.. I can write here now. was looking at it with the wrong account. I changed it using GlobalAlignment.

@vjlux
Copy link
Collaborator Author

vjlux commented May 31, 2024

Please also update the CAPTURE.md to include the origin output: https://github.com/microsoft/lamar-benchmark/blob/main/CAPTURE.md

I wonder if I should just go with proc/global_alignment but this would be more involved.

CAPTURE.md Outdated Show resolved Hide resolved
scantools/run_navvis_to_capture.py Outdated Show resolved Hide resolved
scantools/run_navvis_to_capture.py Outdated Show resolved Hide resolved
scantools/run_navvis_to_capture.py Outdated Show resolved Hide resolved
scantools/scanners/navvis/origin_parser.py Outdated Show resolved Hide resolved
scantools/scanners/navvis/origin_parser.py Outdated Show resolved Hide resolved
Copy link
Contributor

@pablospe pablospe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@vjlux vjlux merged commit fa6f540 into main Jun 11, 2024
2 checks passed
@vjlux vjlux deleted the user/lugruber/parse_origin branch June 11, 2024 11:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants