Don't call UpdateViewport if viewport management is disabled (#3964)

* don't call UpdateViewport if viewport management is disabled * Update ViewportManagerWithPlatformFeatures.cpp Remove trailing s Co-authored-by: Stephen L Peters <[email protected]>
microsoft · Jan 19, 2021 · 773ef30 · 773ef30
1 parent 0edd463
commit 773ef30
Showing 1 changed file with 11 additions and 8 deletions.
diff --git a/dev/Repeater/ViewportManagerWithPlatformFeatures.cpp b/dev/Repeater/ViewportManagerWithPlatformFeatures.cpp
@@ -420,15 +420,18 @@ void ViewportManagerWithPlatformFeatures::EnsureScroller()
             parent = CachedVisualTreeHelpers::GetParent(parent);
         }
 
-        if (!m_scroller)
+        if (!m_managingViewportDisabled)
         {
-            // We usually update the viewport in the post arrange handler. But, since we don't have
-            // a scroller, let's do it now.
-            UpdateViewport(winrt::Rect{});
-        }
-        else if (!m_managingViewportDisabled)
-        {
-            m_effectiveViewportChangedRevoker = m_owner->EffectiveViewportChanged(winrt::auto_revoke, { this, &ViewportManagerWithPlatformFeatures::OnEffectiveViewportChanged });
+            if (!m_scroller)
+            {
+                // We usually update the viewport in the post arrange handler. 
+                // But, since we don't have a scroller, let's do it now.
+                UpdateViewport(winrt::Rect{});
+            }
+            else
+            {
+                m_effectiveViewportChangedRevoker = m_owner->EffectiveViewportChanged(winrt::auto_revoke, { this, &ViewportManagerWithPlatformFeatures::OnEffectiveViewportChanged });
+            }
         }
 
         m_ensuredScroller = true;