Don't call UpdateViewport if viewport management is disabled #3964
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
marcelwgn
approved these changes
Jan 16, 2021
RBrid
approved these changes
Jan 19, 2021
Remove trailing s
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Jul 10, 2022
Kinnara
added a commit
to Kinnara/ModernWpf
that referenced
this pull request
Jul 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In certain cases, it is possible to end up calling UpdateViewport when the viewport management is disabled. Viewport management is disabled for non virtualizing layouts. This update is to avoid doing that call.
I don't think see an easy way to test this yet.