TabItemsChanged doesn't seem to get raised anymore in WinUI 2.8 #8388
Comments
This was referenced Apr 13, 2023
microsoft-github-policy-service bot
pushed a commit
to microsoft/terminal
that referenced
this issue
Apr 17, 2023
…15178) TL;DR: we stopped getting `TabView.TabItemsChanged`. This meant that the tab view would change its apparent order, but we wouldn't change the backing tab order. I'm fixing this by grabbing the index of the tab that starts the drag, and the index of the tab view item at the end of the drag, and using that to reorder our backing list. Closes #15121 Upstream microsoft/microsoft-ui-xaml#8388 Regressed in #15078 - I'm pretty confident about this, since I've got a 1.18.931 build of the Terminal with tear-out, but not MUX 2.8.
|
@zadjii-msft would you mind closing this one out now that we've verified it? thx! |
|
Oh yea derp. I forgot that their bot doesn't auto-close issues when a PR comes along to fix them. (See #8420). Thanks again folks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
WinUI version: 2.8.2
downstream: microsoft/terminal#15121
After updating to 2.8, Terminal's TabView no longer seems to raise
TabItemsChangedevents anymore. Breakpoints in the Terminal get hit forTabDragStartingandTabDragCompleted, but we don't get aTabItemsChanged.Looking at the diff between 2.7 and 2.8, it looks like there was some code added around
m_isDraggingwhich might end up filtering out theTabItemsChangedevents. #6632 introduced the one I'm thinking of, and that was first available in a 2.8.0 prerelease.I think I can work around it with some finagling on my side, but this was a serious unexpected regression others might want to know about.
The text was updated successfully, but these errors were encountered: