-
Notifications
You must be signed in to change notification settings - Fork 677
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding InfoBar Control #3325
Adding InfoBar Control #3325
Conversation
…oked up IconSource, renamed ShowCloseButton -> IsUserDismissable
…epending on if the content fits.
The static analysis build failure that happened a last week was exclusive to the release build. Can you make sure there isn't a build failure locally when you run a release build? |
I don't have a failure on my machine on release. |
@teaP can you pull master into this branch to pickup the pipeline stability change that went in today? |
Is the current UI design style set in stone or is there room for suggestions? |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
Hi @jamers99, thanks for your feedback! What specific design are you referring to from that issue? However, yes, the design is rather set in stone. For this control we worked with our team of Fluent designers to help create this UI. |
Huh, another control? Seems a bit redundant... Curious about the reasoning for that? |
Originally it would have been a mode for the same control, but the team decided to keep the InfoBar a Bar, and to have the floating/overlayed control be something else - possibly named InfoCard. |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
/azp run |
Azure Pipelines successfully started running 1 pipeline(s). |
This change adds the InfoBar control, spec here. It looks like this:
I think it's all pretty straightforward. The only special thing is the custom layout panel, InfoBarPanel, which lays out things horizontally, unless they don't fit, and then it switches to vertical; it has attached properties to handle different margins depending on the layout.