Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding InfoBar Control #3325

Merged
merged 35 commits into from
Oct 27, 2020
Merged

Adding InfoBar Control #3325

merged 35 commits into from
Oct 27, 2020

Conversation

teaP
Copy link
Contributor

@teaP teaP commented Sep 24, 2020

This change adds the InfoBar control, spec here. It looks like this:
image

I think it's all pretty straightforward. The only special thing is the custom layout panel, InfoBarPanel, which lays out things horizontally, unless they don't fit, and then it switches to vertical; it has attached properties to handle different margins depending on the layout.

@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Sep 24, 2020
@StephenLPeters StephenLPeters added area-InfoBar team-Controls Issue for the Controls team needs-triage Issue needs to be triaged by the area owners and removed needs-triage Issue needs to be triaged by the area owners labels Sep 24, 2020
@StephenLPeters
Copy link
Contributor

StephenLPeters commented Oct 19, 2020

The static analysis build failure that happened a last week was exclusive to the release build. Can you make sure there isn't a build failure locally when you run a release build?

@teaP
Copy link
Contributor Author

teaP commented Oct 19, 2020

The static analysis build failure that happened a last week was exclusive to the release build. Can you make sure there isn't a build failure locally when you run a release build?

I don't have a failure on my machine on release.

@StephenLPeters
Copy link
Contributor

@teaP can you pull master into this branch to pickup the pipeline stability change that went in today?

@jamers99
Copy link

Is the current UI design style set in stone or is there room for suggestions?
It doesn't quite feel like a Fluent UI or WinUI control, perhaps a touch of shadow or corner radius would do it?
I really like the look of the design for this control: #913

@teaP
Copy link
Contributor Author

teaP commented Oct 22, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@gabbybilka
Copy link
Member

Is the current UI design style set in stone or is there room for suggestions?
It doesn't quite feel like a Fluent UI or WinUI control, perhaps a touch of shadow or corner radius would do it?
I really like the look of the design for this control: #913

Hi @jamers99, thanks for your feedback! What specific design are you referring to from that issue?

However, yes, the design is rather set in stone. For this control we worked with our team of Fluent designers to help create this UI.

@jamers99
Copy link

jamers99 commented Oct 22, 2020

What specific design are you referring to from that issue?

This here. I think the color banner on the left would make more sense in the case for the InfoBar, but you get the idea:
image

However, yes, the design is rather set in stone.

Bummer, okay, what's the process for doing some UI tweaks?

@mdtauk
Copy link
Contributor

mdtauk commented Oct 22, 2020

What specific design are you referring to from that issue?

This here. I think the color banner on the left would make more sense in the case for the InfoBar, but you get the idea:
image

However, yes, the design is rather set in stone.

Bummer, okay, what's the process for doing some UI tweaks?

I would put that into the InfoCard control design that comes next

@jamers99
Copy link

I would put that into the InfoCard control design that comes next

Huh, another control? Seems a bit redundant... Curious about the reasoning for that?

@mdtauk
Copy link
Contributor

mdtauk commented Oct 22, 2020

I would put that into the InfoCard control design that comes next

Huh, another control? Seems a bit redundant... Curious about the reasoning for that?

Originally it would have been a mode for the same control, but the team decided to keep the InfoBar a Bar, and to have the floating/overlayed control be something else - possibly named InfoCard.

@teaP
Copy link
Contributor Author

teaP commented Oct 22, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@teaP
Copy link
Contributor Author

teaP commented Oct 27, 2020

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-InfoBar team-Controls Issue for the Controls team
Projects
None yet
Development

Successfully merging this pull request may close these issues.