Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken link in winui3_migration.md #6312

Merged
merged 3 commits into from
Dec 2, 2021

Conversation

krschau
Copy link
Contributor

@krschau krschau commented Nov 15, 2021

Fix broken link to try-convert documentation.

Fix broken link.
@ghost ghost added the needs-triage Issue needs to be triaged by the area owners label Nov 15, 2021
@krschau
Copy link
Contributor Author

krschau commented Nov 15, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

See the [try-convert documentation](https://github.com/dotnet/try-convert/blob/feature/winui/WinUIConvert.md) for more information on these code analyzers and how to automoate the process with try-convert.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link in "It is recommended to use the try-convert tool for the full conversion process. try-convert will automate most of the conversion steps.", i.e. https://github.com/dotnet/try-convert/blob/feature/winui is still broken in the beginning of the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! I think all the links are good now.

Copy link
Member

@asklar asklar Nov 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #6391 - this will ensure links don't get broken in the future.

Fix/remove additional broken links.
Link specifically to WinUI feature
@krschau krschau removed the needs-triage Issue needs to be triaged by the area owners label Nov 22, 2021
@krschau
Copy link
Contributor Author

krschau commented Nov 22, 2021

/azp run

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@krschau krschau merged commit 3f179e8 into main Dec 2, 2021
@krschau krschau deleted the user/krschau/broken-tryconvert-link branch December 2, 2021 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants