Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix broken link in winui3_migration.md #6312

Merged
merged 3 commits into from
Dec 2, 2021
Merged

Fix broken link in winui3_migration.md #6312

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f6ae791
Update winui3_migration.md
krschau Nov 15, 2021
1527098
Update winui3_migration.md
krschau Nov 17, 2021
d706a58
Update winui3_migration.md
krschau Nov 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions docs/winui3_migration.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
# Migrating a UWP App To WinUI3

**It is recommended to use the [try-convert](https://github.com/dotnet/try-convert/blob/feature/winui) tool for the full conversion process.**
**[try-convert](https://github.com/dotnet/try-convert/blob/feature/winui) will automate most of the conversion steps.**
**It is recommended to use the [try-convert](https://github.com/dotnet/try-convert/tree/feature/winui) tool for the full conversion process.**
**try-convert will automate most of the conversion steps.**

## Background

Expand All @@ -18,4 +18,4 @@ This porting assistance is provided in the form of Roslyn Analyzers and Code Fix
- A Code Analyzer provides on the fly code inspections for C# and creates diagnostics.
- A Code Fix consumes the diagnostics created by the Code Analyzer and modifies the C# file in-line.

See the [try-convert documentation](https://github.com/dotnet/try-convert/blob/feature/winui) for more information on these code analyzers and how to automoate the process with [try-convert](https://github.com/dotnet/try-convert/blob/feature/winui/WinUIConvert.md).
See the [try-convert documentation](https://github.com/dotnet/try-convert/blob/feature/winui/WinUIConvert.md) for more information on these code analyzers and how to automoate the process with try-convert.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link in "It is recommended to use the try-convert tool for the full conversion process. try-convert will automate most of the conversion steps.", i.e. https://github.com/dotnet/try-convert/blob/feature/winui is still broken in the beginning of the file.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catch! I think all the links are good now.

Copy link
Member

@asklar asklar Nov 28, 2021 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #6391 - this will ensure links don't get broken in the future.