Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dev - 5.10.1 #1390

Merged
merged 6 commits into from
May 31, 2022
Merged

Dev - 5.10.1 #1390

merged 6 commits into from
May 31, 2022

Conversation

absci
Copy link
Contributor

@absci absci commented May 18, 2022

No description provided.

@codecov
Copy link

codecov bot commented May 18, 2022

Codecov Report

Merging #1390 (911ae24) into master (0997c25) will decrease coverage by 0.02%.
The diff coverage is n/a.

❗ Current head 911ae24 differs from pull request most recent head 109b8bc. Consider uploading reports for the commit 109b8bc to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1390      +/-   ##
==========================================
- Coverage   83.63%   83.61%   -0.03%     
==========================================
  Files          22       22              
  Lines        7829     7853      +24     
==========================================
+ Hits         6548     6566      +18     
- Misses       1281     1287       +6     
Impacted Files Coverage Δ
.../php-8.0.15-src/ext/sqlsrv/shared/core_results.cpp
...php-8.0.15-src/ext/pdo_sqlsrv/shared/core_sqlsrv.h
...x86/php-8.0.15-src/ext/sqlsrv/shared/core_util.cpp
...phpdev/vs16/x86/php-8.0.15-src/ext/sqlsrv/conn.cpp
...phpdev/vs16/x86/php-8.0.15-src/ext/sqlsrv/util.cpp
...6/php-8.0.15-src/ext/sqlsrv/shared/core_stream.cpp
...s16/x86/php-8.0.15-src/ext/pdo_sqlsrv/pdo_util.cpp
...php-8.0.15-src/ext/pdo_sqlsrv/php_pdo_sqlsrv_int.h
...phpdev/vs16/x86/php-8.0.15-src/ext/sqlsrv/stmt.cpp
...s16/x86/php-8.0.15-src/ext/pdo_sqlsrv/pdo_stmt.cpp
... and 34 more

Copy link
Contributor

@David-Engel David-Engel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good from the function side. @v-mabarw should review from the C++ technical perspective.

@absci absci merged commit 16459fa into master May 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants