Replaced requests with httpx 0.18 #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Thanks @grantv9! It looks like there are some functions in your branch still using requests (items in msticpy/data/azure). It would be great to replace all instances if this PR. Also there are some linting errors coming up. You can find the linters we use here: Please let us know if you have any questions |
|
You're welcome @petebryan! I fixed the msticpy/data/azure directory and updated the tests accordingly (using the |
Merged
|
Submitted a new PR that fixes the last two pytest errors from test_pkg_imports.py and test_sumologic_driver.py |
petebryan
approved these changes
Feb 1, 2022
juju4
pushed a commit
to juju4/msticpy
that referenced
this pull request
Jun 5, 2022
Replaced requests with httpx 0.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #172