Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cybereason #306

Merged
merged 10 commits into from
Feb 1, 2022
Merged

Cybereason #306

merged 10 commits into from
Feb 1, 2022

Conversation

FlorianBracq
Copy link
Collaborator

Answers #305 but requires #285 and #291 to work as expected.

petebryan
petebryan previously approved these changes Jan 29, 2022
Copy link
Contributor

@petebryan petebryan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test should pass once #291 merged in. Will do that and confirm.

@petebryan
Copy link
Contributor

@FlorianBracq one additional thing, could we ask that you please add a short documentation page under docs/source/data_acquisiton. Just something very short to show users how to access the use the provider.

@petebryan
Copy link
Contributor

Thanks for the docs @FlorianBracq - looks like you have an issue with the Cybereason tests. It looks like the mocked data in the test has this format:
"elementValues": {
"users": {
"totalValues": 5,
"elementValues": [],
"totalSuspicious": 0,
"totalMalicious": 0,
"guessedTotal": 0,
}
But the driver looks for a "values" key in there. Not sure if this is a mocked data or a driver issue here.

@petebryan petebryan linked an issue Feb 1, 2022 that may be closed by this pull request
@FlorianBracq
Copy link
Collaborator Author

Thanks for the docs @FlorianBracq - looks like you have an issue with the Cybereason tests. It looks like the mocked data in the test has this format: "elementValues": { "users": { "totalValues": 5, "elementValues": [], "totalSuspicious": 0, "totalMalicious": 0, "guessedTotal": 0, } But the driver looks for a "values" key in there. Not sure if this is a mocked data or a driver issue here.

@petebryan: that was a PEBKAC ;)

@petebryan petebryan merged commit 98b9a70 into microsoft:main Feb 1, 2022
juju4 pushed a commit to juju4/msticpy that referenced this pull request Jun 5, 2022
@FlorianBracq FlorianBracq deleted the Cybereason branch January 2, 2023 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for Cybereason
2 participants