Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed autogen script when no user input for profile IDs #259

Merged
merged 2 commits into from
Oct 6, 2023
Merged

Fixed autogen script when no user input for profile IDs #259

merged 2 commits into from
Oct 6, 2023

Conversation

kuqin12
Copy link
Contributor

@kuqin12 kuqin12 commented Oct 6, 2023 •
edited by makubacki
Loading

Description

The previous change of adding profile ID into the autogenerated headers caused the build to break when there is no input for this parameter supplied: microsoft/mu_tiano_platforms#723.

This change added the corresponding edge case handling and updated the autogenerated header formatting so that the output is self-consistent instead of strictly following the user input.

  • Impacts functionality?
    • Functionality - Does the change ultimately impact how firmware functions?
    • Examples: Add a new library, publish a new PPI, update an algorithm, ...
  • Impacts security?
    • Security - Does the change have a direct security impact on an application,
      flow, or firmware?
    • Examples: Crypto algorithm change, buffer overflow fix, parameter
      validation improvement, ...
  • Breaking change?
    • Breaking change - Will anyone consuming this change experience a break
      in build or boot behavior?
    • Examples: Add a new library class, move a module to a different repo, call
      a function in a new library class in a pre-existing module, ...
  • Includes tests?
    • Tests - Does the change include any explicit test code?
    • Examples: Unit tests, integration tests, robot tests, ...
  • Includes documentation?
    • Documentation - Does the change contain explicit documentation additions
      outside direct code modifications (and comments)?
    • Examples: Update readme file, add feature readme file, link to documentation
      on an a separate Web page, ...

How This Was Tested

This was tested on the top of QEMU Q35 platform and confirmed building and booting to shell.

Integration Instructions

N/A

@github-actions github-actions bot added the language:python Pull requests that update Python code label Oct 6, 2023
@kuqin12 kuqin12 requested a review from shrugupt October 6, 2023 13:58
@kuqin12 kuqin12 added the type:bug Something isn't working label Oct 6, 2023
@kuqin12 kuqin12 requested a review from apop5 October 6, 2023 13:58
@kuqin12 kuqin12 changed the title Fixing for non-profile input case Fixed autogen script when no user input for profile IDs Oct 6, 2023
@kuqin12 kuqin12 enabled auto-merge (squash) October 6, 2023 15:07
@kuqin12 kuqin12 requested a review from makubacki October 6, 2023 15:07
@kuqin12 kuqin12 merged commit 2fe056c into microsoft:main Oct 6, 2023
19 checks passed
@ProjectMuBot ProjectMuBot mentioned this pull request Oct 6, 2023
Merged
ProjectMuBot added a commit to microsoft/mu_tiano_platforms that referenced this pull request Oct 6, 2023
@ProjectMuBot
Bumps Features/CONFIG from 2.0.3 to 2.0.5
debe4ee 
Introduces 4 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/c8a8d931956b119ad9dc07ab1061878218edd324">c8a8d9</a> pip: bump regex from 2023.8.8 to 2023.10.3 (<a href="https://github.com/microsoft/mu_feature_config/pull/256">#256</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/c22b3d46dec728ab91866afee8e4771bf27d76cb">c22b3d</a> pip: bump edk2-pytool-library from 0.18.1 to 0.18.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/257">#257</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/c37d64826d8386ec853f3e0a1c9e5323e834fda7">c37d64</a> Update autogen script to generate profile ids array on UEFI builds (<a href="https://github.com/microsoft/mu_feature_config/pull/258">#258</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/2fe056cb449830c2e19fadb013bfe3549a9bf548">2fe056</a> Fixed autogen script when no user input for profile IDs (<a href="https://github.com/microsoft/mu_feature_config/pull/259">#259</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
makubacki pushed a commit to microsoft/mu_tiano_platforms that referenced this pull request Oct 7, 2023
@ProjectMuBot @makubacki
Bumps Features/CONFIG from 2.0.3 to 2.0.5
cb9621f 
Introduces 4 new commits in [Features/CONFIG](https://github.com/microsoft/mu_feature_config.git).

<details>
<summary>Commits</summary>
<ul>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/c8a8d931956b119ad9dc07ab1061878218edd324">c8a8d9</a> pip: bump regex from 2023.8.8 to 2023.10.3 (<a href="https://github.com/microsoft/mu_feature_config/pull/256">#256</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/c22b3d46dec728ab91866afee8e4771bf27d76cb">c22b3d</a> pip: bump edk2-pytool-library from 0.18.1 to 0.18.2 (<a href="https://github.com/microsoft/mu_feature_config/pull/257">#257</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/c37d64826d8386ec853f3e0a1c9e5323e834fda7">c37d64</a> Update autogen script to generate profile ids array on UEFI builds (<a href="https://github.com/microsoft/mu_feature_config/pull/258">#258</a>)</li>
<li><a href="https://github.com/microsoft/mu_feature_config/commit/2fe056cb449830c2e19fadb013bfe3549a9bf548">2fe056</a> Fixed autogen script when no user input for profile IDs (<a href="https://github.com/microsoft/mu_feature_config/pull/259">#259</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>
kuqin12 pushed a commit to microsoft/mu_tiano_platforms that referenced this pull request Oct 9, 2023
@ProjectMuBot
Bump Features/CONFIG from 2.0.3 to 2.0.5 (#726)
14119b0 
Bumps Features/CONFIG from `2.0.3` to `2.0.5`


Introduces 4 new commits in
[Features/CONFIG](https://github.com/microsoft/mu_feature_config.git).

<details>
<summary>Commits</summary>
<ul>
<li><a
href="https://github.com/microsoft/mu_feature_config/commit/c8a8d931956b119ad9dc07ab1061878218edd324">c8a8d9</a>
pip: bump regex from 2023.8.8 to 2023.10.3 (<a
href="https://github.com/microsoft/mu_feature_config/pull/256">#256</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_config/commit/c22b3d46dec728ab91866afee8e4771bf27d76cb">c22b3d</a>
pip: bump edk2-pytool-library from 0.18.1 to 0.18.2 (<a
href="https://github.com/microsoft/mu_feature_config/pull/257">#257</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_config/commit/c37d64826d8386ec853f3e0a1c9e5323e834fda7">c37d64</a>
Update autogen script to generate profile ids array on UEFI builds (<a
href="https://github.com/microsoft/mu_feature_config/pull/258">#258</a>)</li>
<li><a
href="https://github.com/microsoft/mu_feature_config/commit/2fe056cb449830c2e19fadb013bfe3549a9bf548">2fe056</a>
Fixed autogen script when no user input for profile IDs (<a
href="https://github.com/microsoft/mu_feature_config/pull/259">#259</a>)</li>
</ul>
</details>

Signed-off-by: Project Mu Bot <[email protected]>

Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@makubacki makubacki makubacki approved these changes

@shrugupt shrugupt shrugupt approved these changes

@apop5 apop5 apop5 approved these changes

Assignees
No one assigned
Labels
language:python Pull requests that update Python code type:bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kuqin12 @makubacki @shrugupt @apop5