Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Features/CONFIG from 2.0.3 to 2.0.4 #723

Closed

Conversation

ProjectMuBot
Copy link
Collaborator

Bumps Features/CONFIG from 2.0.3 to 2.0.4

Introduces 3 new commits in Features/CONFIG.

Commits
  • c8a8d9 pip: bump regex from 2023.8.8 to 2023.10.3 (#256)
  • c22b3d pip: bump edk2-pytool-library from 0.18.1 to 0.18.2 (#257)
  • c37d64 Update autogen script to generate profile ids array on UEFI builds (#258)

Signed-off-by: Project Mu Bot [email protected]

@ProjectMuBot ProjectMuBot added type:dependencies Pull requests that update a dependency file type:submodules Pull requests that update submodules labels Oct 6, 2023
@kuqin12 kuqin12 self-assigned this Oct 6, 2023
kuqin12 added a commit to microsoft/mu_feature_config that referenced this pull request Oct 6, 2023
# Preface

Please ensure you have read the [contribution
docs](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md) prior
to submitting the pull request. In particular,
[pull request
guidelines](https://github.com/microsoft/mu/blob/master/CONTRIBUTING.md#pull-request-best-practices).

## Description

The previous change of adding profile ID into the autogenerated headers
caused the build to break when there is no input for this parameter
supplied: microsoft/mu_tiano_platforms#723.

This change added the corresponding edge case handling and updated the
autogenerated header formatting so that the output is self-consistent
instead of strictly following the user input.

For each item, place an "x" in between `[` and `]` if true. Example:
`[x]`.
_(you can also check items in the GitHub UI)_

- [x] Impacts functionality?
- **Functionality** - Does the change ultimately impact how firmware
functions?
- Examples: Add a new library, publish a new PPI, update an algorithm,
...
- [ ] Impacts security?
- **Security** - Does the change have a direct security impact on an
application,
    flow, or firmware?
  - Examples: Crypto algorithm change, buffer overflow fix, parameter
    validation improvement, ...
- [ ] Breaking change?
- **Breaking change** - Will anyone consuming this change experience a
break
    in build or boot behavior?
- Examples: Add a new library class, move a module to a different repo,
call
    a function in a new library class in a pre-existing module, ...
- [ ] Includes tests?
  - **Tests** - Does the change include any explicit test code?
  - Examples: Unit tests, integration tests, robot tests, ...
- [ ] Includes documentation?
- **Documentation** - Does the change contain explicit documentation
additions
    outside direct code modifications (and comments)?
- Examples: Update readme file, add feature readme file, link to
documentation
    on an a separate Web page, ...

## How This Was Tested

This was tested on the top of QEMU Q35 platform and confirmed building
and booting to shell.

## Integration Instructions

N/A
@kuqin12
Copy link
Contributor

kuqin12 commented Oct 6, 2023

Fix submodule. Released 2.0.5

@makubacki
Copy link
Member

Fix submodule. Released 2.0.5

I'm going to close this PR and rerun again for it to pick up 2.0.5 in a new PR.

@makubacki makubacki closed this Oct 6, 2023
@kuqin12 kuqin12 deleted the projectmubot/submodules/mu_feature_config/2.0.4 branch April 8, 2024 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:dependencies Pull requests that update a dependency file type:submodules Pull requests that update submodules
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants