[Bug]: Improve HID Descriptor Parsing Compatibility

[makubacki]

Is there an existing issue for this?

• I have searched existing issues

Current Behavior

Recently support was added in HidPkg for a Rust-based HID stack in #324.

It's been observed that a USB stall error is encountered with HID devices in some cases. We suspect those devices do not implement the full set of descriptor reads from the HID specification.

An example of such a problem on the QEMU emulated platform:

XhcCheckUrbResult: STALL_ERROR! Completecode = 6
Recovery Halted Slot = 1,Dci = 1
XhcResetEndpoint: Slot = 0x1, Dci = 0x1
XhcControlTransfer: error - Device Error, transfer - 2
[UsbGetFullHidDescriptor] unexpected failure reading HID descriptor: Device Error, Status: 0x2

ASSERT_EFI_ERROR (Status = Device Error)
ASSERT [UsbHidDxe] HidPkg\UsbHidDxe\UsbHidDxe.c(726): !(((INTN)(RETURN_STATUS)(Status)) < 0)

That QEMU Q35 platform can be used to verify changes.

Expected Behavior

A USB stall error should not be encountered as frequently trying to read HID descriptors from HID class devices.

At least in the case of QEMU, we found that (hw/usb/dev-hid.c) all descriptor type requests from the HID 1.1 specification are not supported.

Steps To Reproduce

1. Boot QemuQ35Pkg firmware with default settings using the --FlashRom command
2. Review the boot log in Build/BUILDLOG_QemuQ35Pkg_Run.txt (boots to EFI shell by default)

Build Environment

- OS(s): N/A
- Tool Chain(s): N/A
- Targets Impacted:
  - QEMU virtual platform

Version Information

- PR: #324
- Mu Plus Release v2023020002.0.2

Urgency

Low

Are you going to fix this?

Someone else needs to fix it

Do you need maintainer feedback?

No maintainer feedback needed

Anything else?

No response

[makubacki]

Assigning to @joschock to investigate reworking some of the retrieval logic.