UefiHidDxe: Change HID descriptor read algorithm #339
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
makubacki
approved these changes
Oct 19, 2023
…r range of devices.
joschock
force-pushed
the
personal/joschock/hid_descriptor_read_improvement
branch
from
2655bfd
to
7106736
Compare
kenlautner
approved these changes
Oct 20, 2023
ProjectMuBot
added a commit
to microsoft/mu_tiano_platforms
that referenced
this pull request
Oct 20, 2023
Introduces 1 new commits in [Common/MU](https://github.com/microsoft/mu_plus.git). <details> <summary>Commits</summary> <ul> <li><a href="https://github.com/microsoft/mu_plus/commit/310592e057a25a9c737a35ea5c19c005352e347e">310592</a> UefiHidDxe: Change HID descriptor read algorithm (<a href="https://github.com/microsoft/mu_plus/pull/339">#339</a>)</li> </ul> </details> Signed-off-by: Project Mu Bot <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #338
Description
Updates the algorithm used to read the HID descriptor from HID devices. Empirical testing indicates that some devices do not support reading the HID descriptor via the class-specific Get_Report() method described in USB HID 1.11. This changes the HID read to read the entire configuration descriptor and parse the HID descriptor out of the larger structure, and gives compatibility with a broader range of devices.
Supports a broader range of devices.
How This Was Tested
Verified against emulated USB devices in QEMU.
Integration Instructions
N/A