-
Notifications
You must be signed in to change notification settings - Fork 8.3k
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Stop updating AutoSuggestBox on selection redux (#18010)
I wrote a big comment next to the changes I made. This is a redo of #17961 which had various issues. Closes #17916 Closes #18070 ## Validation Steps Performed * Pressing Enter within the input line doesn't crash ✅ * Type "Cour" and pick Courier New, press Save = Saved ✅ * Pick any other font from the dropdown, press Save = Saved ✅ * Picking an option dismisses focus but not to the tab row ✅ * The first time after launching the SUI, when the setting is still unmodified, when you focus the box and pick an option, it'll unfocus the box ✅ * When the setting is unmodified, and you pick the default (Cascadia Mono), it'll still unfocus the box ✅
- Loading branch information
Showing
4 changed files
with
47 additions
and
16 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters