Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preview: Selecting fonts #18070

Closed
Jaykul opened this issue Oct 17, 2024 · 3 comments · Fixed by #18010
Closed

Preview: Selecting fonts #18070

Jaykul opened this issue Oct 17, 2024 · 3 comments · Fixed by #18010
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.

Comments

@Jaykul
Copy link
Contributor

Jaykul commented Oct 17, 2024

Windows Terminal version

1.22.2702.0

Windows build number

10.0.22635.0

Other Software

I actually have more than one problem with the font selection in Windows Terminal Preview.

  1. When trying to select fonts in Settings -> Profiles: Defaults -> Appearance: Font Face ... it crashes to desktop if I hit "Enter" while typing in the font selection text box

  2. When typing in the font selection box, if I stop typing and select from the list, and then hit save, it reverts to only the part I typed (and then saves) resulting an error popup that the font doesn't exist.

Steps to reproduce

  1. Open Settings -> Profiles: Defaults -> Appearance ... and click in the Font Face text box, and press Enter.

Then reopen Terminal and try again ...

  1. Type part of a font name in the Font Face box
  2. Stop typing and select your font from the list
  3. Hit save

Expected Behavior

I should be able to use my keyboard and mouse together for settings

Actual Behavior

Terminal crashes and pops up error messages.
Here's a video of the second problem, in case I'm confusing

WindowsTerminal_2024-10-16_23-12-04.mp4
@Jaykul Jaykul added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 17, 2024
@Jaykul Jaykul changed the title Preview: Selecting fallback fonts Preview: Selecting fonts Oct 17, 2024
@lhecker
Copy link
Member

lhecker commented Oct 17, 2024

This is a known issue, first reported here: #17987
Because of that we've rolled back the offending change: #17989
Currently I'm redoing the change without the bugs: #18010

Unfortunately, it'll take a little longer for the fix to be released. Thank you for the report though!

@zadjii-msft zadjii-msft mentioned this issue Oct 23, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Oct 23, 2024
@zadjii-msft zadjii-msft added Product-Terminal The new Windows Terminal. Area-Settings UI Anything specific to the SUI labels Oct 23, 2024
@carlos-zamora
Copy link
Member

Thanks Leonard. We'll mark this as a /dup of #17989

@microsoft-github-policy-service Microsoft GitHub Policy Service
Copy link
Contributor

Hi! We've identified this issue as a duplicate of another one that already exists on this Issue Tracker. This specific instance is being closed in favor of tracking the concern over on the referenced thread. Thanks for your report!

@microsoft-github-policy-service microsoft-github-policy-service bot added Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Oct 23, 2024
DHowett pushed a commit that referenced this issue Oct 23, 2024
@lhecker
Stop updating AutoSuggestBox on selection redux (#18010)
8d3f12b 
I wrote a big comment next to the changes I made.
This is a redo of #17961 which had various issues.

Closes #17916
Closes #18070 

## Validation Steps Performed
* Pressing Enter within the input line doesn't crash ✅
* Type "Cour" and pick Courier New, press Save = Saved ✅
* Pick any other font from the dropdown, press Save = Saved ✅
* Picking an option dismisses focus but not to the tab row ✅
* The first time after launching the SUI, when the setting is still
  unmodified, when you focus the box and pick an option,
  it'll unfocus the box ✅
* When the setting is unmodified, and you pick the default
  (Cascadia Mono), it'll still unfocus the box ✅
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-Settings UI Anything specific to the SUI In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Resolution-Duplicate There's another issue on the tracker that's pretty much the same thing.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Stop updating AutoSuggestBox on selection redux microsoft/terminal
4 participants
@Jaykul @lhecker @carlos-zamora @zadjii-msft