Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MUX 2.8: left padding on tab row is larger than 2.7 #15326

Closed
DHowett opened this issue May 10, 2023 · 0 comments · Fixed by #15339
Closed

MUX 2.8: left padding on tab row is larger than 2.7 #15326

DHowett opened this issue May 10, 2023 · 0 comments · Fixed by #15339
Assignees
@zadjii-msft
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.18

Comments

@DHowett
Copy link
Member

DHowett commented May 10, 2023

image (2)
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels May 10, 2023
@PankajBhojwani PankajBhojwani added the Severity-Blocking We won't ship a release like this! No-siree. label May 10, 2023
@PankajBhojwani PankajBhojwani added this to the Terminal v1.18 milestone May 10, 2023
@PankajBhojwani PankajBhojwani added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Issue-Bug It either shouldn't be doing this or needs an investigation. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels May 10, 2023
@microsoft-github-policy-service microsoft-github-policy-service bot removed the Needs-Tag-Fix Doesn't match tag requirements label May 10, 2023
zadjii-msft added a commit that referenced this issue May 12, 2023
@zadjii-msft
Restore the tab padding
a32b7aa 
Honestly, I don't really know where it regressed. There isn't time for me to go digging.

See also
* #15313
* #15164

Closes #15326
@zadjii-msft zadjii-msft mentioned this issue May 12, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label May 12, 2023
DHowett pushed a commit that referenced this issue May 12, 2023
@zadjii-msft
Restore the tab padding (#15339)
d0f66b9 
Honestly, I don't really know where it regressed. There isn't time for
me to go digging.

See also
* #15313
* #15164

Closes #15326
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label May 12, 2023
DHowett pushed a commit that referenced this issue May 12, 2023
@zadjii-msft @DHowett
Restore the tab padding (#15339)
5c6e626 
Honestly, I don't really know where it regressed. There isn't time for
me to go digging.

See also
* #15313
* #15164

Closes #15326

(cherry picked from commit d0f66b9)
Service-Card-Id: 89193703
Service-Version: 1.18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.18
Development

Successfully merging a pull request may close this issue.

Restore the tab padding microsoft/terminal
3 participants
@DHowett @zadjii-msft @PankajBhojwani