Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update MUX to 2.8.4 #15313

Merged
merged 4 commits into from
May 10, 2023
Merged

Update MUX to 2.8.4 #15313

merged 4 commits into from
May 10, 2023

Conversation

zadjii-msft
Copy link
Member

Reverts #15164, because that's fixed upstream now.

Closes #15139.

Reverts #15178, but also closes #15121, because that's fixed upstream.

see also:

@microsoft-github-policy-service microsoft-github-policy-service bot added Issue-Bug It either shouldn't be doing this or needs an investigation. Area-User Interface Issues pertaining to the user interface of the Console or Terminal Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. labels May 8, 2023
lhecker
lhecker reviewed May 10, 2023
View reviewed changes
src/cascadia/TerminalApp/TabManagement.cpp
// Arguments:
// - sender: the control that originated this event
// - eventArgs: the event's constituent arguments
void TerminalPage::_OnTabItemsChanged(const IInspectable& /*sender*/, const Windows::Foundation::Collections::IVectorChangedEventArgs& eventArgs)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should really start using an observable item collection instead of manipulating the tab view list directly. It might many of the animation bugs we have too...

@DHowett DHowett merged commit 48eee4d into main May 10, 2023
@DHowett DHowett deleted the dev/migrie/b/revert-mux-2.8-bodge branch May 10, 2023 18:04
PKRoma pushed a commit to PKRoma/Terminal that referenced this pull request May 12, 2023
@zadjii-msft
PRE-MERGE microsoft#15313 Update MUX to 2.8.4
15c2272
zadjii-msft added a commit that referenced this pull request May 12, 2023
@zadjii-msft
Restore the tab padding
a32b7aa 
Honestly, I don't really know where it regressed. There isn't time for me to go digging.

See also
* #15313
* #15164

Closes #15326
@zadjii-msft zadjii-msft mentioned this pull request May 12, 2023
Merged
DHowett pushed a commit that referenced this pull request May 12, 2023
@zadjii-msft
Restore the tab padding (#15339)
d0f66b9 
Honestly, I don't really know where it regressed. There isn't time for
me to go digging.

See also
* #15313
* #15164

Closes #15326
DHowett pushed a commit that referenced this pull request May 12, 2023
@zadjii-msft @DHowett
Restore the tab padding (#15339)
5c6e626 
Honestly, I don't really know where it regressed. There isn't time for
me to go digging.

See also
* #15313
* #15164

Closes #15326

(cherry picked from commit d0f66b9)
Service-Card-Id: 89193703
Service-Version: 1.18
@tusharsnx tusharsnx mentioned this pull request Apr 16, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DHowett DHowett DHowett approved these changes

@lhecker lhecker lhecker approved these changes

@carlos-zamora carlos-zamora Awaiting requested review from carlos-zamora

@PankajBhojwani PankajBhojwani Awaiting requested review from PankajBhojwani

Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal Issue-Bug It either shouldn't be doing this or needs an investigation. Priority-1 A description (P1) Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. zBugBash-Consider
Projects
None yet
Milestone
No milestone
3 participants
@zadjii-msft @DHowett @lhecker