We should change the SUB control glyph to U+2426 #16558
Labels
In-PR
This issue has a related PR
Issue-Feature
Complex enough to require an in depth planning process and actual budgeted, scheduled work.
Needs-Tag-Fix
Doesn't match tag requirements
Needs-Triage
It's a new issue that the core contributor team needs to triage at the next triage meeting
Comments
j4james
added
the
Issue-Feature
microsoft-github-policy-service
bot
added
Needs-Triage
1 task
DHowett
pushed a commit
that referenced
this issue
Jan 16, 2024
Up to now we've using `U+2E2E` (reverse question mark) to represent the `SUB` control glyph. This PR changes the glyph to `U+2426` (substitute form two), which is also rendered as a reverse question mark, but is more semantically correct. The original `SUB` control rendering was implemented in PR #15075. I've manually confirmed that `printf "\x1A"` is now shown as a reverse question mark in OpenConsole when using the Cascadia Code font. That would not previously have worked, because `U+2E2E` is not supported by Cascadia Code. Closes #16558
DHowett
pushed a commit
that referenced
this issue
Jan 22, 2024
Up to now we've using `U+2E2E` (reverse question mark) to represent the `SUB` control glyph. This PR changes the glyph to `U+2426` (substitute form two), which is also rendered as a reverse question mark, but is more semantically correct. The original `SUB` control rendering was implemented in PR #15075. I've manually confirmed that `printf "\x1A"` is now shown as a reverse question mark in OpenConsole when using the Cascadia Code font. That would not previously have worked, because `U+2E2E` is not supported by Cascadia Code. Closes #16558 (cherry picked from commit 92f9ff9) Service-Card-Id: 91559316 Service-Version: 1.19
DHowett
pushed a commit
that referenced
this issue
Jan 23, 2024
Up to now we've using `U+2E2E` (reverse question mark) to represent the `SUB` control glyph. This PR changes the glyph to `U+2426` (substitute form two), which is also rendered as a reverse question mark, but is more semantically correct. The original `SUB` control rendering was implemented in PR #15075. I've manually confirmed that `printf "\x1A"` is now shown as a reverse question mark in OpenConsole when using the Cascadia Code font. That would not previously have worked, because `U+2E2E` is not supported by Cascadia Code. Closes #16558 (cherry picked from commit 92f9ff9) Service-Card-Id: 91559315 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Description of the new feature/enhancement
On most DEC terminals, the glyph generated by a
SUBcontrol character is a reverse question mark. We're currently usingU+2E2E, which is visually OK, but semantically it would be better if we usedU+2426(substitute form two). They look more or less the same, but the difference is thatU+2426was specifically intended to represent a substitute control.Also note that we're already using
U+2426for the unmapped positions in the VT character sets, and ideally those should match theSUBcontrol character. The other benefit is that Cascadia Code has a glyph forU+2426but not forU+2E2E, so only the former shows up correctly in conhost (at least when using Cascadia Code).Proposed technical implementation details (optional)
Replace the character below with
\u2426.terminal/src/terminal/parser/OutputStateMachineEngine.cpp
Line 91 in a4445ed
The text was updated successfully, but these errors were encountered: