Change the SUB control glyph to U+2426 #16559
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
the
Issue-Feature
lhecker
approved these changes
Jan 16, 2024
DHowett
pushed a commit
that referenced
this pull request
Jan 22, 2024
Up to now we've using `U+2E2E` (reverse question mark) to represent the `SUB` control glyph. This PR changes the glyph to `U+2426` (substitute form two), which is also rendered as a reverse question mark, but is more semantically correct. The original `SUB` control rendering was implemented in PR #15075. I've manually confirmed that `printf "\x1A"` is now shown as a reverse question mark in OpenConsole when using the Cascadia Code font. That would not previously have worked, because `U+2E2E` is not supported by Cascadia Code. Closes #16558 (cherry picked from commit 92f9ff9) Service-Card-Id: 91559316 Service-Version: 1.19
DHowett
pushed a commit
that referenced
this pull request
Jan 23, 2024
Up to now we've using `U+2E2E` (reverse question mark) to represent the `SUB` control glyph. This PR changes the glyph to `U+2426` (substitute form two), which is also rendered as a reverse question mark, but is more semantically correct. The original `SUB` control rendering was implemented in PR #15075. I've manually confirmed that `printf "\x1A"` is now shown as a reverse question mark in OpenConsole when using the Cascadia Code font. That would not previously have worked, because `U+2E2E` is not supported by Cascadia Code. Closes #16558 (cherry picked from commit 92f9ff9) Service-Card-Id: 91559315 Service-Version: 1.18
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of the Pull Request
Up to now we've using
U+2E2E(reverse question mark) to represent theSUBcontrol glyph. This PR changes the glyph toU+2426(substituteform two), which is also rendered as a reverse question mark, but is
more semantically correct.
References and Relevant Issues
The original
SUBcontrol rendering was implemented in PR #15075.Validation Steps Performed
I've manually confirmed that
printf "\x1A"is now shown as a reversequestion mark in OpenConsole when using the Cascadia Code font. That
would not previously have worked, because
U+2E2Eis not supported byCascadia Code.
PR Checklist