Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn autoMarkPrompts on by default in 1.22 #17632

Closed
Tracked by #15845
zadjii-msft opened this issue Jul 30, 2024 · 0 comments · Fixed by #17761
Closed
Tracked by #15845

Turn autoMarkPrompts on by default in 1.22 #17632

zadjii-msft opened this issue Jul 30, 2024 · 0 comments · Fixed by #17761
Assignees
@zadjii-msft
Labels
Area-Suggestions Anything related to tasks or the suggestions UI (sxnui) In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Milestone
Terminal v1.22

Comments

@zadjii-msft
Copy link
Member

This should help with shell_integration in oh-my-posh and the suggestions UI. That'll prevent pwsh -> cmd from just leaving all the text as the currentCommandline
@zadjii-msft zadjii-msft added the Area-Suggestions Anything related to tasks or the suggestions UI (sxnui) label Jul 30, 2024
@zadjii-msft zadjii-msft added this to the Terminal v1.22 milestone Jul 30, 2024
@zadjii-msft zadjii-msft self-assigned this Jul 30, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 30, 2024
@carlos-zamora carlos-zamora added Product-Terminal The new Windows Terminal. Issue-Task It's a feature request, but it doesn't really need a major design. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting Needs-Tag-Fix Doesn't match tag requirements labels Jul 31, 2024
@microsoft-github-policy-service microsoft-github-policy-service bot added the Needs-Tag-Fix Doesn't match tag requirements label Jul 31, 2024
@zadjii-msft zadjii-msft mentioned this issue Aug 20, 2024
Open
zadjii-msft added a commit that referenced this issue Aug 20, 2024
@zadjii-msft
Set the default for autoMarkPrompts to true
030f594 
As we discussed in bug bash.

There's really no downside to us enabling it by default (and leaving showMarksOnScrollbar: false).
It'll mark lines as "prompts" when the user hits enter. This will have a couple good side effects:
* When folks have right-aligned prompts (like, from oh-my-posh), the `enter`
  will terminate where shell integration thinks the command is, so that the
  right-prompt doesn't end up in the commandline history
* the scrollToMark actions will Just Work without any other shell integration

Closes #17632
@zadjii-msft zadjii-msft mentioned this issue Aug 21, 2024
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@zadjii-msft zadjii-msft

Labels
Area-Suggestions Anything related to tasks or the suggestions UI (sxnui) In-PR This issue has a related PR Issue-Task It's a feature request, but it doesn't really need a major design. Needs-Tag-Fix Doesn't match tag requirements Product-Terminal The new Windows Terminal.
Projects
None yet
Milestone
Terminal v1.22
Development

Successfully merging a pull request may close this issue.

Set the default for autoMarkPrompts to true microsoft/terminal
2 participants
@carlos-zamora @zadjii-msft