Set the default for autoMarkPrompts to true
#17761
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As we discussed in bug bash. There's really no downside to us enabling it by default (and leaving showMarksOnScrollbar: false). It'll mark lines as "prompts" when the user hits enter. This will have a couple good side effects: * When folks have right-aligned prompts (like, from oh-my-posh), the `enter` will terminate where shell integration thinks the command is, so that the right-prompt doesn't end up in the commandline history * the scrollToMark actions will Just Work without any other shell integration Closes #17632
microsoft-github-policy-service
bot
added
Issue-Task
carlos-zamora
approved these changes
Aug 21, 2024
microsoft-github-policy-service
bot
requested review from
PankajBhojwani,
carlos-zamora,
DHowett and
lhecker
DHowett
approved these changes
Aug 21, 2024
microsoft-github-policy-service
bot
removed
the
Needs-Second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we discussed in bug bash.
There's really no downside to us enabling it by default (and leaving showMarksOnScrollbar: false). It'll mark lines as "prompts" when the user hits enter. This will have a couple good side effects:
enterwill terminate where shell integration thinks the command is, so that the right-prompt doesn't end up in the commandline historyCloses #17632