-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix font axes/features not working on DPI change #12492
Conversation
I believe this issue is easier to fix if you replace this: terminal/src/cascadia/TerminalControl/ControlCore.cpp Lines 927 to 929 in 349b767
with this: _updateFont(); An additional benefit would be that it's easier to reason about our application state if all font related changes go through Oh and this bug probably also exists for |
@lhecker's suggestion makes a lot more sense, PR has been updated to use |
Hello @DHowett! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
|
From chat: nevermind, it doesn't fix it ;P |
🎉 Handy links: |
🎉 Handy links: |
When the dpi is changed, call
updateFont()
instead ofTriggerFontChange
, thismeans that we continue to use the existing font features/axes
Closes #11287