Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix font axes/features not working on DPI change #12492

Merged
4 commits merged into from
Feb 16, 2022
Merged

Fix font axes/features not working on DPI change #12492

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
382675c
overload updatefont
PankajBhojwani Feb 15, 2022
ab6a0ec
use _updateFont instead
PankajBhojwani Feb 15, 2022
26f02e8
add comment to explain
PankajBhojwani Feb 15, 2022
37c25d9
Remove unused variable
lhecker Feb 15, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 2 additions & 5 deletions src/cascadia/TerminalControl/ControlCore.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -917,16 +917,13 @@ namespace winrt::Microsoft::Terminal::Control::implementation
return;
}

const auto dpi = (float)(scale * USER_DEFAULT_SCREEN_DPI);

const auto actualFontOldSize = _actualFont.GetSize();

auto lock = _terminal->LockForWriting();
_compositionScale = scale;

_renderer->TriggerFontChange(::base::saturated_cast<int>(dpi),
_desiredFont,
_actualFont);
// _updateFont relies on the new _compositionScale set above
_updateFont();
PankajBhojwani marked this conversation as resolved.
Show resolved Hide resolved

const auto actualFontNewSize = _actualFont.GetSize();
if (actualFontNewSize != actualFontOldSize)
Expand Down