Don't auto-dismiss the warning dialog on launch #15273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
microsoft-github-policy-service
bot
added
Issue-Bug
This comment has been minimized.
This comment has been minimized.
DHowett
reviewed
May 1, 2023
Didn't seem like it. I might be able to filter based off if the old window rect and the new one are the same, but that might not work for the initial show |
carlos-zamora
approved these changes
May 2, 2023
Comment on lines
+1261
to
+1268
| // Don't set our state to Initialized until after the call to ShowWindow. | ||
| // When we call ShowWindow, the OS will also send us a WM_MOVE, which we'll | ||
| // then use to try and dismiss an open dialog. This creates the unintended | ||
| // side effect of immediately dismissing the initial warning dialog, if | ||
| // there were settings load warnings. | ||
| // | ||
| // In AppHost::_WindowMoved, we'll make sure we're at least initialized | ||
| // before dismissing open dialogs. |
There was a problem hiding this comment.
i mean, at this point:
// BODGY
carlos-zamora
added
Needs-Second
microsoft-github-policy-service
bot
requested review from
PankajBhojwani,
carlos-zamora,
DHowett and
lhecker
lhecker
approved these changes
May 2, 2023
microsoft-github-policy-service
bot
deleted the
dev/migrie/b/15170-auto-dismiss-warnings
branch
microsoft-github-policy-service
bot
removed
the
Needs-Second
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently,
ShowWindowalso sends aWM_MOVE, which we then turn around and use to dismiss open dialogs.Closes #15170
Regressed in #13811