Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Settings error/warning dialog seems to self-dismiss on startup #15170

Closed
ianjoneill opened this issue Apr 12, 2023 · 1 comment · Fixed by #15273
Closed

Settings error/warning dialog seems to self-dismiss on startup #15170

ianjoneill opened this issue Apr 12, 2023 · 1 comment · Fixed by #15273
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Milestone
Terminal v1.18

Comments

@ianjoneill
Copy link
Contributor

ianjoneill commented Apr 12, 2023 •
edited
Loading

Windows Terminal version

56d451d

Windows build number

10.0.22621.1555

Other Software

No response

Steps to reproduce

  1. Checkout the main branch at 56d451d
  2. Make your settings file invalid
  3. Start Terminal

Expected Behavior

The settings error dialog should be displayed.

Actual Behavior

The settings error dialog displays for a fraction of a second and then disappears. See video below - you can just see a glimpse of the dialog. This also happens if you've got warnings (which is how I found it originally). This didn't happen whilst I was developing #15082 (which was merged with main at 0105807) - as I tested the duplicate environment variables warning numerous times, so I'd guess this is caused by #15078.

ErrorsOnStartup.mp4
@ianjoneill ianjoneill added Issue-Bug It either shouldn't be doing this or needs an investigation. Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 12, 2023
@zadjii-msft zadjii-msft added Area-User Interface Issues pertaining to the user interface of the Console or Terminal Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree. and removed Needs-Triage It's a new issue that the core contributor team needs to triage at the next triage meeting labels Apr 12, 2023
@zadjii-msft zadjii-msft added this to the Terminal v1.18 milestone Apr 12, 2023
@zadjii-msft
Copy link
Member

image

zadjii-msft added a commit that referenced this issue May 1, 2023
@zadjii-msft
Don't auto-dismiss the warning dialog on launch
efedd2c 
Closes #15170
@zadjii-msft zadjii-msft mentioned this issue May 1, 2023
Merged
@microsoft-github-policy-service microsoft-github-policy-service bot added the In-PR This issue has a related PR label May 1, 2023
microsoft-github-policy-service bot pushed a commit that referenced this issue May 2, 2023
@zadjii-msft
Don't auto-dismiss the warning dialog on launch (#15273)
4feeef2 
Apparently, `ShowWindow` also sends a `WM_MOVE`, which we then turn
around and use to dismiss open dialogs.

Closes #15170

Regressed in #13811
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Area-User Interface Issues pertaining to the user interface of the Console or Terminal In-PR This issue has a related PR Issue-Bug It either shouldn't be doing this or needs an investigation. Product-Terminal The new Windows Terminal. Severity-Blocking We won't ship a release like this! No-siree.
Projects
None yet
Milestone
Terminal v1.18
Development

Successfully merging a pull request may close this issue.

Don't auto-dismiss the warning dialog on launch microsoft/terminal
2 participants
@ianjoneill @zadjii-msft