Make ploc translations predictable #16924
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhecker
added
the
Area-Build
lhecker
commented
Mar 23, 2024
| $source = Join-Path $_.Directory "../en-US/$($_.Name)" | ||
| $target = $_ | ||
|
|
||
| $ploc = ./tools/ConvertTo-PseudoLocalization.ps1 -Path $source |
There was a problem hiding this comment.
(This file is at the very end of the diff.)
DHowett
approved these changes
Mar 23, 2024
zadjii-msft
approved these changes
Mar 25, 2024
DHowett
pushed a commit
that referenced
this pull request
Apr 16, 2024
(cherry picked from commit 77d5e23) Service-Card-Id: 92350444 Service-Version: 1.19
DHowett
pushed a commit
that referenced
this pull request
Apr 16, 2024
(cherry picked from commit 77d5e23) Service-Card-Id: 92350470 Service-Version: 1.20
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears as if our official ploc translations use a per-file hash
as the seed for generating random pseudo-localization characters.
This works poorly for us since we have these translations hooked up
to our CI to submit PRs with the latest changes. We do want to get
the latest proper translations but merging 1000s of lines of ploc
changes every time is unneccessary.
This PR replicates LocStudio's pseudo-localizations in PowerShell
but it uses a per-key seed for the RNG.