Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add aria2 to tools list (step 2) #229

Merged
merged 11 commits into from
Nov 2, 2021
Merged

Conversation

JackBoosY
Copy link
Contributor

@JackBoosY JackBoosY commented Oct 25, 2021

  1. Add aria2 to the list of tools
  2. Add the aria2 path to the cmake parameters.

Requires microsoft/vcpkg#20971 first.

src/vcpkg/build.cpp Outdated Show resolved Hide resolved
JackBoosY and others added 4 commits October 25, 2021 18:02
include/vcpkg/tools.h Show resolved Hide resolved
@JackBoosY JackBoosY marked this pull request as draft October 27, 2021 07:16
@JackBoosY JackBoosY marked this pull request as ready for review October 27, 2021 07:52
@BillyONeal
Copy link
Member

Well I didn't mean to push my suggestions into your branch but when I attempted to push to my demo branch it pushed to your branch instead.

Can you take a look at the changes I submitted, and confirm that you agree with them? Otherwise, feel free to chop my edits off (git push -f) and do something else. Point is though that we should find the aria2 from the system and always return that rather than potentially sending broken values into cmake.

@JackBoosY
Copy link
Contributor Author

Test result on Linux:

usr@usr:/home/vcpkg# ./vcpkg fetch aria2
/usr/bin/aria2c

Please note apt only provide aria2 version 1.33.1, the user may need to compile and install it manually. @BillyONeal

@BillyONeal BillyONeal merged commit 1e0c7dc into microsoft:main Nov 2, 2021
@BillyONeal
Copy link
Member

Thanks for adding the fun fetch!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants