Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vcpkg] Add aria2 as vcpkg required tool (step 1) #20971

Merged
merged 7 commits into from
Nov 3, 2021
Merged

[vcpkg] Add aria2 as vcpkg required tool (step 1) #20971

merged 7 commits into from
Nov 3, 2021

Conversation

JackBoosY
Copy link
Contributor

Related: #20585.

@JackBoosY JackBoosY added category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. labels Oct 25, 2021
@JackBoosY JackBoosY marked this pull request as ready for review October 25, 2021 05:45
@JackBoosY JackBoosY changed the title Add aria2 as vcpkg required tool Add aria2 as vcpkg required tool (step 1) Oct 25, 2021
@PhoebeHui PhoebeHui changed the title Add aria2 as vcpkg required tool (step 1) [vcpkg] Add aria2 as vcpkg required tool (step 1) Oct 25, 2021
@PhoebeHui PhoebeHui added the info:reviewed Pull Request changes follow basic guidelines label Oct 25, 2021
This was referenced Oct 25, 2021
Merged
Merged
@JackBoosY
Copy link
Contributor Author

cc @BillyONeal

BillyONeal
BillyONeal requested changes Oct 25, 2021
View reviewed changes
scripts/vcpkgTools.xml Outdated Show resolved Hide resolved
@JackBoosY JackBoosY removed the info:reviewed Pull Request changes follow basic guidelines label Oct 26, 2021
@JackBoosY JackBoosY added the info:reviewed Pull Request changes follow basic guidelines label Oct 26, 2021
BillyONeal
BillyONeal reviewed Oct 27, 2021
View reviewed changes
scripts/vcpkgTools.xml Outdated Show resolved Hide resolved
@BillyONeal BillyONeal added requires:author-response and removed info:reviewed Pull Request changes follow basic guidelines labels Oct 27, 2021
JackBoosY
JackBoosY commented Oct 27, 2021
View reviewed changes
scripts/vcpkgTools.xml Outdated Show resolved Hide resolved
@BillyONeal BillyONeal added the requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof label Oct 28, 2021
BillyONeal
BillyONeal approved these changes Oct 28, 2021
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@strega-nil / @strega-nil-ms confirmed this gets through the hash check but gets stopped by the unknown .bz2 extension. This is good to me as long as there's a tool update and we check that vcpkg fetch aria2 on a Mac machine works.

@JackBoosY
Copy link
Contributor Author

@BillyONeal Ready to merge?

BillyONeal
BillyONeal approved these changes Nov 3, 2021
View reviewed changes
Copy link
Member

@BillyONeal BillyONeal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed that this works as expected now on a MacOS box!

@BillyONeal BillyONeal added info:reviewed Pull Request changes follow basic guidelines and removed requires:tool-release An issue that has been fixed in the microsoft/vcpkg-tool repo and is waiting for a release thereof labels Nov 3, 2021
@BillyONeal BillyONeal merged commit 975822a into microsoft:master Nov 3, 2021
@JackBoosY JackBoosY deleted the dev/jack/add_aria2_required branch November 3, 2021 07:49
@MonicaLiu0311 MonicaLiu0311 mentioned this pull request Jun 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillyONeal BillyONeal BillyONeal approved these changes

@PhoebeHui PhoebeHui PhoebeHui approved these changes

@github-actions github-actions[bot] github-actions[bot] approved these changes

Assignees

@PhoebeHui PhoebeHui

Labels
category:vcpkg-feature The issue is a new capability of the tool that doesn’t already exist and we haven’t committed info:internal This PR or Issue was filed by the vcpkg team. info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@JackBoosY @BillyONeal @PhoebeHui