[scripts-audit] vcpkg_extract_source_archive #18517
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PhoebeHui
added
category:scripts-audit
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
strega-nil-ms
force-pushed
the
vcpkg_extract_source_archive
branch
from
7d40311
to
8fb7ff8
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Neumann-A
reviewed
Jun 28, 2021
51 tasks
BillyONeal
reviewed
Jun 28, 2021
There was a problem hiding this comment.
Maybe we need to talk as a team about this, but I don't think we should be deprecating things that our catalog does. The exercise of fixing the catalog to comply with the deprecated thing also helps the team better understand what the potential impact of a deprecation is.
BillyONeal
approved these changes
Jun 29, 2021
|
Discussion offline: we should avoid adding a third overload that must be maintained forever -- instead any improvements should go into the existing preferred overload and we should simply make |
|
Closed for rollup PR #18838 |
strega-nil-ms
pushed a commit
to strega-nil/vcpkg
that referenced
this pull request
Jul 13, 2021
[scripts-audit] vcpkg_extract_source_archive
BillyONeal
pushed a commit
that referenced
this pull request
Jul 14, 2021
* [rollup:2021-07-06 1/8] PR #18272 (@strega-nil) [scripts-audit] vcpkg_from_* * [rollup:2021-07-06 2/8] PR #18319 (@strega-nil) [scripts-audit] add guidelines for cmake * [rollup 2021-07-06 3/8] PR #18410 (@mheyman) [vcpkg-cmake-config] documentation fix * [rollup:2021-07-06 4/8] PR #18488 (@strega-nil) [scripts-audit] vcpkg_execute_* * [rollup:2021-07-06 5/8] PR #18517 (@strega-nil) [scripts-audit] vcpkg_extract_source_archive * [rollup:2021-07-06 6/8] PR #18674 (@NancyLi1013) [vcpkg doc] Update examples * [rollup:2021-07-06 7/8] PR #18695 (@JackBoosY) [vcpkg] Update the minimum version of vcpkg * [rollup:2021-07-06 8/8] PR #18758 (@ras0219-msft) [vcpkg_from_git] Fix error if downloads folder does not exist * build docs! * fix bond:*-windows * fix nmap Co-authored-by: nicole mazzuca <[email protected]> Co-authored-by: Michael Heyman <[email protected]> Co-authored-by: NancyLi1013 <[email protected]> Co-authored-by: JackBoosY <[email protected]> Co-authored-by: Robert Schumacher <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR audits
vcpkg_extract_source_archiveandvcpkg_extract_source_archive_exto follow in line with issue #17691.Additionally, it changes the "default function" back to
vcpkg_extract_source_archive.This is quite a sizeable change, so it needs serious CR from the team.