[rollup:2021-07-06] Rollup PR #18838
Conversation
strega-nil-ms
commented
Jul 6, 2021
•
strega-nil-ms
commented
- PR [scripts-audit] vcpkg_from_* #18272 (@strega-nil)
- PR [scripts-audit] add guidelines for cmake #18319 (@strega-nil)
- PR [vcpkg-cmake-config] documentation fix #18410 (@mheyman)
- PR [scripts-audit] vcpkg_execute_* #18488 (@strega-nil)
- PR [scripts-audit] vcpkg_extract_source_archive #18517 (@strega-nil)
- PR [vcpkg doc] Update examples #18674 (@NancyLi1013)
- PR [vcpkg] Update the minimum version of vcpkg #18695 (@JackBoosY)
- PR [vcpkg_from_git] Fix error if downloads folder does not exist #18758 (@ras0219-msft)
strega-nil-ms
force-pushed
the
rollup-2021-07-06
branch
from
c6c7140
to
fb006cf
Compare
JackBoosY
added
category:scripts-audit
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
tensoflow:x64-osx would be skipped in baseline, see #18812 |
[scripts-audit] vcpkg_from_*
[scripts-audit] add guidelines for cmake
[vcpkg-cmake-config] documentation fix
strega-nil-ms
force-pushed
the
rollup-2021-07-06
branch
2 times, most recently
from
4bb5dbc
to
a0b8334
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
strega-nil-ms
force-pushed
the
rollup-2021-07-06
branch
from
90a7bd5
to
6e5d746
Compare
|
/azp run |
|
Azure Pipelines successfully started running 1 pipeline(s). |
[scripts-audit] vcpkg_execute_*
[scripts-audit] vcpkg_extract_source_archive
[vcpkg doc] Update examples
[vcpkg] Update the minimum version of vcpkg
[vcpkg_from_git] Fix error if downloads folder does not exist
strega-nil-ms
force-pushed
the
rollup-2021-07-06
branch
from
6e5d746
to
93e97e6
Compare
|
I figured out the problem with the infinite looping. Unfortunately, CMake does not support trailing |
| - Exception: `vcpkg.cmake`'s `find_package`. | ||
| - Scripts in the scripts tree should not be expected to need observable changes | ||
| as part of normal operation. | ||
| - Example violation: `vcpkg_acquire_msys()` has hard-coded packages and versions that need updating over time due to the MSYS project dropping old packages. |
There was a problem hiding this comment.
NB: we believe this is a bug. No change requested.
strega-nil-ms
force-pushed
the
rollup-2021-07-06
branch
from
93e97e6
to
f7f9e48
Compare
| - This `cmake_minimum_required` should be bumped every time a new version | ||
| of CMake is added to `vcpkgTools.xml`, as should the | ||
| `cmake_minimum_required` in all of the helper `CMakeLists.txt` files. | ||
| - `vcpkg.cmake` must assume a version of CMake back to 3.1 in general |
There was a problem hiding this comment.
@strega-nil In the context of #18898, I created a test port for the minimum cmake version.
Even with #18898, at least CMake 3.4 is needed to use vcpkg.cmake:
All scripts in scripts/toolchains/ do use string(APPEND ...).
$ git grep -l "string(APPEND" scripts/toolchains
scripts/toolchains/android.cmake
scripts/toolchains/freebsd.cmake
scripts/toolchains/ios.cmake
scripts/toolchains/linux.cmake
scripts/toolchains/mingw.cmake
scripts/toolchains/openbsd.cmake
scripts/toolchains/osx.cmake
scripts/toolchains/windows.cmake
There was a problem hiding this comment.
It even nobody complained that it is 3.15 currently
There was a problem hiding this comment.
hmm, okay. This might argue for updating our minimum supported version to 3.4, since we haven't heard complaints.
There was a problem hiding this comment.
It even nobody complained that it is
3.15currently
I did. And I would have complained earlier if the vcpkg ports I need would be mature enough for usage on Ubuntu 18.04 / CMake 3.10.
