Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kf5textwidgets] new port #19766

Merged
merged 26 commits into from
Sep 14, 2021
Merged

[kf5textwidgets] new port #19766

merged 26 commits into from
Sep 14, 2021

Conversation

wrobelda
Copy link
Contributor

@wrobelda wrobelda commented Aug 27, 2021

Describe the pull request

  • What does your PR fix?

    Adds new kf5textwidgets port.
    Depends on:

  • Which triplets are supported/not supported? Have you updated the CI baseline?

    All official.

  • Does your PR follow the maintainer guide?

    Yes.

  • If you have added/updated a port: Have you run ./vcpkg x-add-version --all and committed the result?

    Yes.

@JonLiu1993 JonLiu1993 self-assigned this Aug 27, 2021
@JonLiu1993 JonLiu1993 added the category:new-port The issue is requesting a new library to be added; consider making a PR! label Aug 27, 2021
@wrobelda
Copy link
Contributor Author

@JonLiu1993 this is now ready for a review, but please notice the dependency I mentioned in my first comment.

@wrobelda wrobelda marked this pull request as ready for review August 27, 2021 14:20
This was referenced Aug 28, 2021
@JonLiu1993 JonLiu1993 added the depends:different-pr This PR or Issue depends on a PR which has been filed label Aug 30, 2021
@wrobelda wrobelda force-pushed the kf5textwidgets branch 2 times, most recently from d78c918 to 1b7984f Compare August 30, 2021 19:02
@wrobelda
Copy link
Contributor Author

wrobelda commented Sep 10, 2021

@wrobelda ,This pr also depends on #20090 ?

@JonLiu1993 not really, the #20016 provided all the fixes for kf5i18n. Once #20090 gets merged, I'll update kf5i18n and remove its patch.

#20016 was merged to master already, so I rebased this PR and it's good to go.

@JonLiu1993 JonLiu1993 added requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. info:reviewed Pull Request changes follow basic guidelines and removed requires:vcpkg-team-review This PR or issue requires someone on the vcpkg team to take a further look. labels Sep 13, 2021
@BillyONeal BillyONeal merged commit f446c96 into microsoft:master Sep 14, 2021
@BillyONeal
Copy link
Member

Thanks again!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
category:new-port The issue is requesting a new library to be added; consider making a PR! info:reviewed Pull Request changes follow basic guidelines
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants