-
Notifications
You must be signed in to change notification settings - Fork 6.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[kf5textwidgets] new port #19766
Merged
Merged
[kf5textwidgets] new port #19766
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JonLiu1993
added
the
category:new-port
The issue is requesting a new library to be added; consider making a PR!
label
Aug 27, 2021
wrobelda
force-pushed
the
kf5textwidgets
branch
from
August 27, 2021 13:49
cfd59f7
to
37ec404
Compare
@JonLiu1993 this is now ready for a review, but please notice the dependency I mentioned in my first comment. |
This was referenced Aug 28, 2021
Merged
wrobelda
force-pushed
the
kf5textwidgets
branch
from
August 28, 2021 15:13
07055df
to
78f898b
Compare
wrobelda
force-pushed
the
kf5textwidgets
branch
from
August 28, 2021 15:35
78f898b
to
59e6c2a
Compare
wrobelda
force-pushed
the
kf5textwidgets
branch
from
August 28, 2021 16:05
59e6c2a
to
bfcafef
Compare
JonLiu1993
added
the
depends:different-pr
This PR or Issue depends on a PR which has been filed
label
Aug 30, 2021
JonLiu1993
reviewed
Aug 30, 2021
JonLiu1993
reviewed
Aug 30, 2021
wrobelda
force-pushed
the
kf5textwidgets
branch
from
August 30, 2021 14:08
bfcafef
to
5b241cc
Compare
wrobelda
force-pushed
the
kf5textwidgets
branch
from
August 30, 2021 14:52
2a29458
to
46529c5
Compare
wrobelda
force-pushed
the
kf5textwidgets
branch
2 times, most recently
from
August 30, 2021 19:02
d78c918
to
1b7984f
Compare
wrobelda
force-pushed
the
kf5textwidgets
branch
from
September 10, 2021 12:06
f52fc5e
to
226d7fd
Compare
JonLiu1993
approved these changes
Sep 13, 2021
JonLiu1993
added
requires:vcpkg-team-review
This PR or issue requires someone on the vcpkg team to take a further look.
info:reviewed
Pull Request changes follow basic guidelines
and removed
requires:vcpkg-team-review
This PR or issue requires someone on the vcpkg team to take a further look.
labels
Sep 13, 2021
Thanks again! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
category:new-port
The issue is requesting a new library to be added; consider making a PR!
info:reviewed
Pull Request changes follow basic guidelines
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request
What does your PR fix?
Adds new kf5textwidgets port.
Depends on:
Which triplets are supported/not supported? Have you updated the CI baseline?
All official.
Does your PR follow the maintainer guide?
Yes.
If you have added/updated a port: Have you run
./vcpkg x-add-version --all
and committed the result?Yes.